After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790979 - omxvideodec: retrieve OMX_IndexParamVideoPortFormat before setting it
omxvideodec: retrieve OMX_IndexParamVideoPortFormat before setting it
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-omx
git master
Other Linux
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-11-29 13:21 UTC by Guillaume Desmottes
Modified: 2017-11-29 17:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
omxvideodec: retrieve OMX_IndexParamVideoPortFormat before setting it (1.32 KB, patch)
2017-11-29 13:21 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2017-11-29 13:21:08 UTC 
.
Comment 1 Guillaume Desmottes 2017-11-29 13:21:28 UTC 
Created attachment 364617 [details] [review]
omxvideodec: retrieve OMX_IndexParamVideoPortFormat before setting it

The usual pattern when setting OMX params is to first get the struct
param, override the values we want to set and then set the updated
param.
We were not doing this with OMX_IndexParamVideoPortFormat and so were
resetting some fields such as OMX_VIDEO_PARAM_PORTFORMATTYPE.xFramerate
Comment 2 Olivier Crête 2017-11-29 13:24:54 UTC 
Review of attachment 364617 [details] [review]:

Looks good
Comment 3 Olivier Crête 2017-11-29 17:42:06 UTC 
Merged.

Attachment 364617 [details] pushed as 56654cc - omxvideodec: retrieve OMX_IndexParamVideoPortFormat before setting it