Created attachment 364588 [details]
diff of list of files between ninja/make dist tarballs

Outside of:

 - .gitignore
 - Autotools self-hosting disted files
 - API reference files
 - Autotools-generated Visual Studio project files

These are the actual differing bits:

+./tests/gobject/ifacecheck.c
+./tests/gobject/ifaceinherit.c
+./tests/gobject/ifaceinit.c

These seems to be missing from the build altogether, so they either should go or they should be plugged in.

+./tests/gobject/run-performance.sh

This is missing from the Autotools build because it requires a Git checkout, so it should be skipped by `git archive`.

Ah, missed this:

+./tests/gio-ls.c

This is missing from the Autotools build altogether, so it either needs to go or it needs to be plugged in. Given that it's a toy test added 10 years ago and touched by two more commits over that period, I favour getting rid of it.

(In reply to Emmanuele Bassi (:ebassi) from comment #2)
> Outside of:
> 
>  - .gitignore
>  - Autotools self-hosting disted files
>  - API reference files
>  - Autotools-generated Visual Studio project files
> 
> These are the actual differing bits:
> 
> +./tests/gobject/ifacecheck.c
> +./tests/gobject/ifaceinherit.c
> +./tests/gobject/ifaceinit.c
> 
> These seems to be missing from the build altogether, so they either should
> go or they should be plugged in.

They should probably be updated to TAP and actually run as part of the test suite (unless it looks like we get similar coverage from other tests).

> +./tests/gobject/run-performance.sh
> 
> This is missing from the Autotools build because it requires a Git checkout,
> so it should be skipped by `git archive`.

I’d be tempted to just drop the shell script (but not performance.c). It looks like the kind of local hack which should be specific to an individual developer.

(In reply to Emmanuele Bassi (:ebassi) from comment #3)
> Ah, missed this:
> 
> +./tests/gio-ls.c
> 
> This is missing from the Autotools build altogether, so it either needs to
> go or it needs to be plugged in. Given that it's a toy test added 10 years
> ago and touched by two more commits over that period, I favour getting rid
> of it.

Yeah, nuke it.

-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glib/issues/1307.