GNOME Bugzilla – Bug 790755
Keywords are no longer searched
Last modified: 2017-12-02 22:03:32 UTC
Created attachment 364263 [details] Screenshot of difference between search results in old and new control-center Since the upgrade to the new layout, the control center search functionality does not search the text inside the panels. It will only search the panel name and panel description. In the previous versions of the control center the search box showed results from the text inside panels. For example: search for "proxy". The expected result would be showing the Network panel but no results are shown instead. See attached screenshot for comparison with previous version.
Created attachment 364486 [details] [review] shell: Include panel "keywords" in the row data This way GtkListBox filter functions can use the "keywords" in order to provide accurate search results.
Review of attachment 364486 [details] [review]: this looks fine. my comment below is more of "ideally" thing that I just noticed while reviewing ::: shell/cc-panel-list.c @@ +900,2 @@ /* And add to the search listbox too */ + search_data = row_data_new (category, id, title, description, keywords, icon); big picture comment, unrelated to this bug: I'm not sure what Georges' original design for this widget was, but it seems like all this data duplication could be avoided by making CcPanelList aware of the CcShellModel and keep a model iter for each row instead of all these copies
(In reply to Rui Matos from comment #2) > big picture comment, unrelated to this bug: > > I'm not sure what Georges' original design for this widget was, but it seems > like all this data duplication could be avoided by making CcPanelList aware > of the CcShellModel and keep a model iter for each row instead of all these > copies You're right. In fact, while I'm preparing to work on the ability of hiding panels under certain conditions, I had this exact thought. One more thing on the to-do list for 3.28 I guess.
(In reply to Rui Matos from comment #2) > I'm not sure what Georges' original design for this widget was, but it seems > like all this data duplication could be avoided by making CcPanelList aware > of the CcShellModel and keep a model iter for each row instead of all these > copies right. (In reply to Georges Basile Stavracas Neto from comment #3) > You're right. In fact, while I'm preparing to work on the ability of hiding > panels under certain conditions, I had this exact thought. > > One more thing on the to-do list for 3.28 I guess. Is this going to be part of the changes you are going to land or you want me to work on it?
Attachment 364486 [details] pushed as aaabf05 - shell: Include panel "keywords" in the row data
(In reply to Felipe Borges from comment #4) > (In reply to Georges Basile Stavracas Neto from comment #3) > > You're right. In fact, while I'm preparing to work on the ability of hiding > > panels under certain conditions, I had this exact thought. > > > > One more thing on the to-do list for 3.28 I guess. > > Is this going to be part of the changes you are going to land or you want me > to work on it? I am going to work on it, unless someone beats me.
*** Bug 791136 has been marked as a duplicate of this bug. ***