GNOME Bugzilla – Bug 790667
The ink supply level bar causes PrinterEntries to vexpand even when that's not wanted
Last modified: 2017-11-21 16:30:06 UTC
.
Created attachment 364121 [details] [review] printer: Don't show the supply level bar by default We were checking for the ink supply level at the callback of the supply bar "draw" signal. This way we were making the the widget visible, causing it to allocate vertical space even when it isn't desired. Now we check for the supply level before setting the visiblity of the supply level widget.
Review of attachment 364121 [details] [review]: Thank you for the patch. It fixes the issue. Push it also to gnome-3-26 branch please. ::: panels/printers/pp-printer-entry.c @@ +232,3 @@ +{ + return !(self->inklevel->marker_levels && self->inklevel->marker_colors && + self->inklevel->marker_names && self->inklevel->marker_types); Check these against NULL please.
Attachment 364121 [details] pushed as 5ac6a0d (gnome-3-26) - printer: Don't show the supply level bar by default Attachment 364121 [details] pushed as 5d4cb8e (master)- printer: Don't show the supply level bar by default