After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790665 - Printer name does not use all available space
Printer name does not use all available space
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Printers
git master
Other Linux
: Normal normal
: ---
Assigned To: Felipe Borges
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-11-21 13:54 UTC by Marek Kašík
Modified: 2017-11-21 16:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
printers: Allow printer name and location labels to hexpand (2.52 KB, patch)
2017-11-21 14:06 UTC, Felipe Borges
none Details | Review
printers: Allow printer name and location labels to hexpand (2.14 KB, patch)
2017-11-21 14:23 UTC, Felipe Borges
committed Details | Review

Description Marek Kašík 2017-11-21 13:54:59 UTC
Printer name is ellipsized even if the Printer panel is resized and has enough space for it.
Also, when resizing the panel, beginning of printer name and model name changes their positions, it should begin on the same coordinate even when resizing.
Comment 1 Felipe Borges 2017-11-21 14:06:34 UTC
Created attachment 364119 [details] [review]
printers: Allow printer name and location labels to hexpand

Since the main control-center window can now be resized, there's
no reason for us to constrain the printer name and location labels
from expanding horizontally.
Comment 2 Felipe Borges 2017-11-21 14:23:16 UTC
Created attachment 364122 [details] [review]
printers: Allow printer name and location labels to hexpand

Since the main control-center window can now be resized, there's
no reason for us to constrain the printer name and location labels
from expanding horizontally.
Comment 3 Marek Kašík 2017-11-21 16:02:25 UTC
Review of attachment 364122 [details] [review]:

Thank you for the patch. This fixes this issue for me. But lets set the xalign also for printer model. Once added, push it to gnome-3-26 and master branches. Thanks.

::: panels/printers/printer-entry.ui
@@ +238,3 @@
                 <property name="halign">start</property>
                 <property name="ellipsize">PANGO_ELLIPSIZE_MIDDLE</property>
+                <property name="xalign">0</property>

Lets do this also for the printer model text.
Comment 4 Felipe Borges 2017-11-21 16:19:52 UTC
Attachment 364122 [details] pushed as a79eef8 (gnome-3-26) - printers: Allow printer name and location labels to hexpand
Attachment 364122 [details] pushed as 950ca7f (master) - printers: Allow printer name and location labels to hexpand