After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790489 - broadway: Add missing dependency to build
broadway: Add missing dependency to build
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Broadway
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-11-17 10:14 UTC by Philip Withnall
Modified: 2017-11-17 10:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
broadway: Add missing dependency to build (1.73 KB, patch)
2017-11-17 10:14 UTC, Philip Withnall
committed Details | Review

Description Philip Withnall 2017-11-17 10:14:39 UTC
Trivial patch attached. Fixes a Jenkins build failure: https://jenkins.freedesktop.org/job/coverity/job/coverity-scan-jhbuild/2780/console

cc  -Igdk/broadway/gdk-broadway@sta -Igdk/broadway -I../../checkout/gtk+/gdk/broadway -I. -I../../checkout/gtk+/ -Igdk -I../../checkout/gtk+/gdk -Isubprojects/libepoxy/include -I../../checkout/gtk+/subprojects/libepoxy/include -Isubprojects/libepoxy/src -I../../checkout/gtk+/subprojects/libepoxy/src -Isubprojects/libepoxy/include/epoxy -I/scratch/coverity-scan-jhbuild/install/include/gdk-pixbuf-2.0 -I/scratch/coverity-scan-jhbuild/install/include/glib-2.0 -I/scratch/coverity-scan-jhbuild/install/lib/glib-2.0/include -I/scratch/coverity-scan-jhbuild/install/include/cairo -I/scratch/coverity-scan-jhbuild/install/include/pixman-1 -I/scratch/coverity-scan-jhbuild/install/include/freetype2 -I/scratch/coverity-scan-jhbuild/install/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libpng12 -I/scratch/coverity-scan-jhbuild/install/include/pango-1.0 -I/scratch/coverity-scan-jhbuild/install/include/gio-unix-2.0/ -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=gnu99 -O2 -g -DG_LOG_USE_STRUCTURED=1 -DGLIB_MIN_REQUIRED_VERSION=GLIB_VERSION_2_52 -DGLIB_MAX_ALLOWED_VERSION=GLIB_VERSION_2_54 '-DGTK_VERSION="3.93.0"' -D_GNU_SOURCE -DG_ENABLE_DEBUG -DG_DISABLE_CAST_CHECKS -fPIC -pthread -DGDK_COMPILATION '-DG_LOG_DOMAIN="Gdk"' -fno-strict-aliasing -Wpointer-arith -Wmissing-declarations -Wimplicit-function-declaration -Wformat=2 -Wformat-nonliteral -Wformat-security -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wundef -Wunused -Wcast-align -Wmissing-noreturn -Wmissing-format-attribute -Wmissing-include-dirs -Wlogical-op -Wswitch-default -Wswitch-enum -Wignored-qualifiers -Werror=redundant-decls -Werror=implicit -Werror=nonnull -Werror=init-self -Werror=main -Werror=missing-braces -Werror=sequence-point -Werror=return-type -Werror=trigraphs -Werror=array-bounds -Werror=write-strings -Werror=address -Werror=int-to-pointer-cast -Werror=pointer-to-int-cast -Werror=empty-body -Werror=write-strings -fvisibility=hidden -MMD -MQ 'gdk/broadway/gdk-broadway@sta/broadway-server.c.o' -MF 'gdk/broadway/gdk-broadway@sta/broadway-server.c.o.d' -o 'gdk/broadway/gdk-broadway@sta/broadway-server.c.o' -c ../../checkout/gtk+/gdk/broadway/broadway-server.c
../../checkout/gtk+/gdk/broadway/broadway-server.c:1139:24: fatal error: clienthtml.h: No such file or directory
 #include "clienthtml.h"
                        ^
compilation terminated.
Comment 1 Philip Withnall 2017-11-17 10:14:44 UTC
Created attachment 363906 [details] [review]
broadway: Add missing dependency to build

The generated file clienthtml.h is #included by broadway-server.c, which
is one of the sources of the broadway library — so clienthtml.h needs to
be one of the sources of that library too.

Signed-off-by: Philip Withnall <withnall@endlessm.com>
Comment 2 Emmanuele Bassi (:ebassi) 2017-11-17 10:18:41 UTC
Review of attachment 363906 [details] [review]:

ACK-by: me
Comment 3 Philip Withnall 2017-11-17 10:39:54 UTC
Attachment 363906 [details] pushed as bd89ff4 - broadway: Add missing dependency to build