After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790396 - build-tools/m4 broken on macOS 10.13 High Sierra
build-tools/m4 broken on macOS 10.13 High Sierra
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: cerbero
git master
Other Mac OS
: Normal major
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-11-15 18:49 UTC by Andrew Achkar
Modified: 2017-11-17 13:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Andrew Achkar 2017-11-15 18:49:45 UTC 
There is a known change to printf-family functions in macOS 10.13 High Sierra that causes unpatched m4 to crash, affecting the build of any recipe that requires m4.

This bug has been discussed here: http://lists.gnu.org/archive/html/bug-gnulib/2017-07/msg00056.html

A patch to build-tools/bison was recently added at git master: https://github.com/GStreamer/cerbero/commit/8cd4cb8eaee7d492d33f8dcc6c97156f5b668e8a

The fix to this bug would be a similar patch being added to the m4 recipe (and any other source that may have a copy of gnu vasnprintf)


Repro instruction:

checkout git master
./cerbero-uninstalled bootstrap

try to run:
build-tools/bin/m4 --version
Illegal instruction: 4


lldb trace:

lldb build-tools/bin/m4
(lldb) target create "build-tools/bin/m4"
Current executable set to 'build-tools/bin/m4' (x86_64).
(lldb) run --version
Process 55454 launched: 'build-tools/bin/m4' (x86_64)
Process 55454 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_INSTRUCTION (code=EXC_I386_INVOP, subcode=0x0)
    frame #0: 0x00007fff73aaea23 libsystem_c.dylib`__vfprintf + 16437
libsystem_c.dylib`__vfprintf:
->  0x7fff73aaea23 <+16437>: ud2
    0x7fff73aaea25 <+16439>: nopl   (%rax)
    0x7fff73aaea28 <+16442>: retq
Target 0: (m4) stopped.
Comment 1 Sebastian Dröge (slomo) 2017-11-15 20:19:40 UTC 
Do you want to provide a patch for this?
Comment 2 Andrew Achkar 2017-11-17 13:18:50 UTC 
(In reply to Sebastian Dröge (slomo) from comment #1)
> Do you want to provide a patch for this?

It appears to have been patched by ystreet: https://github.com/GStreamer/cerbero/commit/cb39eafeeae9296da7ce8e8519bf9ceb3a6dbd5c
https://github.com/GStreamer/cerbero/commit/027c4e5049deea5c43051fd234b497e526b11220