After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790192 - opencv: The plugins are not built using new OpenCV version
opencv: The plugins are not built using new OpenCV version
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.12.3
Other Linux
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-11-10 21:11 UTC by Mario Alfredo Carrillo Arevalo
Modified: 2017-11-23 15:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
This commits update the OpenCV version in configure.ac file (1.03 KB, patch)
2017-11-10 21:11 UTC, Mario Alfredo Carrillo Arevalo 		none Details | Review
This commits update the OpenCV version in configure.ac file (1.03 KB, patch)
2017-11-22 17:02 UTC, Mario Alfredo Carrillo Arevalo 		none Details | Review
This commits update the OpenCV version in configure.ac file (1.04 KB, patch)
2017-11-22 22:33 UTC, Mario Alfredo Carrillo Arevalo 		committed Details | Review

Description Mario Alfredo Carrillo Arevalo 2017-11-10 21:11:46 UTC 
Created attachment 363376 [details] [review]
This commits update the OpenCV version in configure.ac file

The current version described in configure.ac file does not allow to build the OpenCV plugins using 3.3.1 OpenCV version, it should be updated.
Comment 1 Mario Alfredo Carrillo Arevalo 2017-11-21 22:35:48 UTC 
Hi folks, this patch has been tested and it has been included in Clear Linux

https://github.com/clearlinux-pkgs/gst-plugins-bad/blob/master/0003-opencv-Update-version-for-building-plugins.patch

Regards.
Mario.
Comment 2 Sebastian Dröge (slomo) 2017-11-22 07:53:36 UTC 
Comment on attachment 363376 [details] [review]
This commits update the OpenCV version in configure.ac file

Maybe this should be updated to < 3.4? Seems more future-proof
Comment 3 Mario Alfredo Carrillo Arevalo 2017-11-22 16:59:36 UTC 
good idea, thanks.

Regards.
Mario.
Comment 4 Mario Alfredo Carrillo Arevalo 2017-11-22 17:02:35 UTC 
Created attachment 364216 [details] [review]
This commits update the OpenCV version in configure.ac file

T
Comment 5 Sebastian Dröge (slomo) 2017-11-22 21:08:43 UTC 
Comment on attachment 364216 [details] [review]
This commits update the OpenCV version in configure.ac file

I meant < 3.4.0 and not <= 3.3.4
Comment 6 Mario Alfredo Carrillo Arevalo 2017-11-22 22:33:02 UTC 
Created attachment 364237 [details] [review]
This commits update the OpenCV version in configure.ac file

oh sorry, thanks.

Regards.
Mario.
Comment 7 Sebastian Dröge (slomo) 2017-11-23 08:05:59 UTC 
commit b7dad57e9e8b6fb3fd7bf185b4aed4b366a2fc74 (HEAD -> master)
Author: Mario Alfredo Carrillo Arevalo <mario.alfredo.c.arevalo@intel.com>
Date:   Fri Nov 10 13:32:17 2017 -0600

    opencv: Update version for building plugins
    
    This commit allows to build the OpenCV plugin with OpenCV >= 2.3.0 to < 3.4.0.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=790192
Comment 8 Sebastian Dröge (slomo) 2017-11-23 08:06:54 UTC 
Review of attachment 364237 [details] [review]:

::: configure.ac
@@ +2822,3 @@
   dnl seem to be a switch to suppress the warnings the cvcompat.h header
   dnl causes.)
+  PKG_CHECK_MODULES(OPENCV, opencv >= 2.3.0 opencv <= 3.4.0 , [

I changed this to < 3.4.0. 3.4.0 is going to change the API again, potentially. The point is to keep the next API incompatible version out of the version range.
Comment 9 Mario Alfredo Carrillo Arevalo 2017-11-23 15:57:42 UTC 
perfect, thanks for help.

Regards.
Mario.