Created attachment 363157 [details] [review]
qtdemux: Add support vp9 codec

test file available at
https://storage.googleapis.com/wvtemp/tinskip/vp9-dash-test-vectors/vp9-hd/sintel-vp9-hd.mp4

Review of attachment 363157 [details] [review]:

::: gst/isomp4/qtdemux.c
@@ +13938,3 @@
       break;
     case FOURCC_VP80:
+    case FOURCC_vp08:

You probably want to add both to the muxer too, and make the muxer use the official "vp08" one instead. Not sure where "VP80" comes from. Needs some research

(In reply to Sebastian Dröge (slomo) from comment #3)
> Review of attachment 363157 [details] [review] [review]:
> 
> ::: gst/isomp4/qtdemux.c
> @@ +13938,3 @@
>        break;
>      case FOURCC_VP80:
> +    case FOURCC_vp08:
> 
> You probably want to add both to the muxer too, and make the muxer use the
> official "vp08" one instead. Not sure where "VP80" comes from. Needs some
> research

I googled and I'm not sure where the "VP80" came from (for qtdmux)...

https://en.wikipedia.org/wiki/VP8 is saying that the fourcc of vp8 is "VP80".
But, I guess it should be used only for VP8 Video For Windows codec (http://www.optimasc.com/products/vp8vfw/index.html), so I think "vp08" is proper expression in isobmff based on spec.

Best to switch the muxers over to that too then :)

Created attachment 363432 [details] [review]
isomp4: Add support VP9 codec

 ... and change legacy VP8 fourcc "VP80" to official one "vp08"
See also https://www.webmproject.org/vp9/mp4/

Review of attachment 363432 [details] [review]:

Would you mind making 2 patches, one for vp8 and one for VP9 ?

Review of attachment 363432 [details] [review]:

Would you mind making 2 patches, one for vp8 and one for VP9 ?

Created attachment 363462 [details] [review]
[1/2] isomp4: Add support VP9 codec

Add fourcc for VP9 codec and support it by qtdemux and qtmux
See also https://www.webmproject.org/vp9/mp4/

Created attachment 363463 [details] [review]
isomp4: Add official fourcc for VP8 codec

fourcc for VP8 codec is "vp08" defined by spec. To follow it, 
add it to demux and change legacy VP8 fourcc "VP80" to "vp08" in mux.
Also, enable sync table in case of VP8 codec.
See also https://www.webmproject.org/vp9/mp4/

(In reply to Nicolas Dufresne (stormer) from comment #8)
> Review of attachment 363432 [details] [review] [review]:
> 
> Would you mind making 2 patches, one for vp8 and one for VP9 ?

I updated them.

Thanks for splitting these two, thanks for your patches.

Attachment 363463 [details] pushed as 8aa5c59 - isomp4: Add official fourcc for VP8 codec
Attachment 363462 [details] pushed as 93f19b1 - [1/2] isomp4: Add support VP9 codec