After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789956 - Patches to fix several build issues
Patches to fix several build issues
Status: RESOLVED FIXED
Product: java-atk-wrapper
Classification: Applications
Component: general
0.33.x
Other Linux
: Normal normal
: ---
Assigned To: java-atk-wrapper maintainer(s)
java-atk-wrapper maintainer(s)
Depends on:
Blocks: 789959
 
 
Reported: 2017-11-06 09:44 UTC by Fridrich Strba
Modified: 2019-05-29 10:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Quote variables so that an eventual new line does not make an option to be considered command (643 bytes, patch)
2017-11-06 09:44 UTC, Fridrich Strba
none Details | Review
No need to bother with libtool versionning, since this library is is only loaded by java code and expects a simple *.so (1.52 KB, patch)
2017-11-06 09:45 UTC, Fridrich Strba
none Details | Review
This code uses diamond operator and thus cannot be built with java 6 (789 bytes, patch)
2017-11-06 09:46 UTC, Fridrich Strba
none Details | Review
Allow specifying the directories of *.jar and *.properties files on configure time, instead of hardcoding weird paths that don't work with jdk9 anyway (2.33 KB, patch)
2017-11-06 09:47 UTC, Fridrich Strba
none Details | Review
A useless beautification: define JAW_JAR_NAME in configure. This will eventually allow adding in the same place JAW_MODULE_NAME for a modular j-a-w that would work with jdk9 (941 bytes, patch)
2017-11-06 09:50 UTC, Fridrich Strba
none Details | Review
Allow to build j-a-w outside the source tree (2.16 KB, patch)
2017-11-06 09:51 UTC, Fridrich Strba
none Details | Review
Allow to build j-a-w outside the source tree (2.38 KB, patch)
2017-11-06 10:01 UTC, Fridrich Strba
none Details | Review
There is no point to look for both gdk-2.0 and gdk-3.0 in the same time (868 bytes, patch)
2017-11-08 09:19 UTC, Fridrich Strba
none Details | Review
With this patch, one can do make distcheck (7.16 KB, patch)
2017-11-08 10:03 UTC, Fridrich Strba
none Details | Review
Nothing in the build invokes javah, so, we don't need to look for it (673 bytes, patch)
2017-11-08 10:04 UTC, Fridrich Strba
none Details | Review

Description Fridrich Strba 2017-11-06 09:44:37 UTC
Created attachment 363041 [details] [review]
Quote variables so that an eventual new line does not make an option to be considered command

Different patches from my git that make the java-atk-wrapper build better (IMHO)
Comment 1 Fridrich Strba 2017-11-06 09:45:48 UTC
Created attachment 363042 [details] [review]
No need to bother with libtool versionning, since this library is is only loaded by java code and expects a simple *.so
Comment 2 Fridrich Strba 2017-11-06 09:46:33 UTC
Created attachment 363043 [details] [review]
This code uses diamond operator and thus cannot be built with java 6
Comment 3 Fridrich Strba 2017-11-06 09:47:49 UTC
Created attachment 363044 [details] [review]
Allow specifying the directories of *.jar and *.properties files on configure time, instead of hardcoding weird paths that don't work with jdk9 anyway
Comment 4 Fridrich Strba 2017-11-06 09:50:09 UTC
Created attachment 363045 [details] [review]
A useless beautification: define JAW_JAR_NAME in configure. This will eventually allow adding in the same place JAW_MODULE_NAME for a modular j-a-w that would work with jdk9
Comment 5 Fridrich Strba 2017-11-06 09:51:13 UTC
Created attachment 363046 [details] [review]
Allow to build j-a-w outside the source tree
Comment 6 Fridrich Strba 2017-11-06 10:01:06 UTC
Created attachment 363048 [details] [review]
Allow to build j-a-w outside the source tree
Comment 7 Fridrich Strba 2017-11-08 09:19:00 UTC
Created attachment 363191 [details] [review]
There is no point to look for both gdk-2.0 and gdk-3.0 in the same time
Comment 8 Fridrich Strba 2017-11-08 10:03:38 UTC
Created attachment 363193 [details] [review]
With this patch, one can do make distcheck
Comment 9 Fridrich Strba 2017-11-08 10:04:17 UTC
Created attachment 363194 [details] [review]
Nothing in the build invokes javah, so, we don't need to look for it
Comment 10 Samuel Thibault 2019-05-20 19:03:09 UTC
I believe these have been pushed to the repository.