GNOME Bugzilla – Bug 789871
preset: Do not save deprecated properties
Last modified: 2017-11-26 18:26:53 UTC
See commit message.
Created attachment 362907 [details] [review] preset: Do not save deprecated properties It will g_warn uppong desarialization and we should not use thos anyway.
What will g_warn upon deserialisation? GstPreset? Some elements? Arguably there could be a backwards-compatibility issue here - if someone only set the old version of some property and doesn't set the new one then we're dropping the setting entirely, no? Unless we assume that elements will always configure their new versions right when the deprecated ones get set. Which might be a reasonable assumption/requirement to make. Either way it's probably fine, since hardly anyone uses presets anyway ;)
(In reply to Tim-Philipp Müller from comment #2) > What will g_warn upon deserialisation? GstPreset? Some elements? Usually elements do. > Arguably there could be a backwards-compatibility issue here - if someone > only set the old version of some property and doesn't set the new one then > we're dropping the setting entirely, no? Yeah, I know that - I am not sure what would be best in that case. > Unless we assume that elements will always configure their new versions > right when the deprecated ones get set. Which might be a reasonable > assumption/requirement to make. > > Either way it's probably fine, since hardly anyone uses presets anyway ;) Right, this is somehow my view also... I am not 100% convinced by that patch either tbh but I do not see what would be a good solution for that (we get spanned by g_warning in Pitivi when using encoders that have deprecated props (vp8 for example)).
The only alternative I can think of would be a flag to say which properties should be saved for presets or not. There may be a bug about that, or maybe it was about ui hints for properties.
(In reply to Tim-Philipp Müller from comment #4) > The only alternative I can think of would be a flag to say which properties > should be saved for presets or not. There may be a bug about that, or maybe > it was about ui hints for properties. A flag to say what props should *not* be serialized could work, is it worth it? :-)
What would you do about that one?
I'd say just go for it. If there's a problem in practice we can still fix it later :)
Attachment 362907 [details] pushed as 81e10f6 - preset: Do not save deprecated properties
Would backporting be OK? (so we avoid warning in Pitivi 1.0 - not a big deal anyway if you think we should not).