After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789742 - sdpmessage: do not append NULL value for session-level attr
sdpmessage: do not append NULL value for session-level attr
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Mac OS
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-11-01 04:12 UTC by Justin Kim
Modified: 2017-11-01 06:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
sdpmessage: do not append NULL value for session-level attr (1.45 KB, patch)
2017-11-01 04:12 UTC, Justin Kim 		committed Details | Review

Description Justin Kim 2017-11-01 04:12:57 UTC 
Created attachment 362712 [details] [review]
sdpmessage: do not append NULL value for session-level attr

sdpmessage: do not append NULL value for session-level attr

If an attribute is defined without value, the generated text
should be 'a=key' rather than 'a=key:'. For media-level, it
has already been done.
Comment 1 Matthew Waters (ystreet00) 2017-11-01 06:12:12 UTC 
commit d100180ce3838c9705c23ce03e69fa9ba921a5ae
Author: Justin Kim <justin.kim@collabora.com>
Date:   Wed Nov 1 12:44:59 2017 +0900

    sdpmessage: do not append NULL value for session-level attr
    
    If an attribute is defined without value, the generated text
    should be 'a=key' rather than 'a=key:'. For media-level, it
    has already been done.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=789742