After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789699 - Change Install button to "Installing" instantly when pressed
Change Install button to "Installing" instantly when pressed
Status: RESOLVED FIXED
Product: gnome-font-viewer
Classification: Core
Component: general
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-font-viewer-maint
gnome-font-viewer-maint
Depends on:
Blocks:
 
 
Reported: 2017-10-31 10:27 UTC by Stuart Langridge
Modified: 2019-07-05 14:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Freeze button while installing new font (3.36 KB, patch)
2017-12-28 13:10 UTC, Martin Blanchard
none Details | Review

Description Stuart Langridge 2017-10-31 10:27:43 UTC
When opening a font file in gnome-font-viewer, an Install button is present (for not-already-installed fonts). Clicking this button doesn't seem to do anything for a second or two, and then it changes to "Installed" (and is set insensitive). It would be nice if the button when clicked immediately reacted by going insensitive and saying "Installing...", so there isn't that moment of doubt that nothing has happened at all. (It would then obviously change to "Installed" or "Install failed" when the install process completes, a second or so later.)
Comment 1 Bastián Díaz 2017-11-17 21:21:08 UTC
In my case nothing happens when you press the "install" button and after one or two minutes I close the application. When reopening the same typography appears as installed. It is confusing and there should be better feedback when installing a new typeface.
Comment 2 Martin Blanchard 2017-12-28 13:07:46 UTC
(In reply to Bastián Díaz from comment #1)
> In my case nothing happens when you press the "install" button and after one
> or two minutes I close the application. When reopening the same typography
> appears as installed. It is confusing and there should be better feedback
> when installing a new typeface.

If you are running a Wayland session, most probably, your are suffering from Bug #786693. The font configuration update signal is not implemented in gtk+'s wayland backend and gnome-font-viewer relies on it to monitor installed font list...
Comment 3 Martin Blanchard 2017-12-28 13:10:49 UTC
Created attachment 366047 [details] [review]
Freeze button while installing new font

Note that this also set a minimum width of 100px for the install button, thus avoiding weird UI moves during installation.
Comment 4 Martin Blanchard 2018-07-18 22:02:28 UTC
Updated and submitted on GitLab as GNOME/gnome-font-viewer!1 [1].

Comments are very welcome!

[1] https://gitlab.gnome.org/GNOME/gnome-font-viewer/merge_requests/1
Comment 5 Cosimo Cecchi 2019-07-05 14:35:45 UTC
Closing this, the above MR has been merged long ago.