After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789666 - meson: dist po/meson.build
meson: dist po/meson.build
Status: RESOLVED FIXED
Product: at-spi
Classification: Platform
Component: at-spi2-core
unspecified
Other All
: Normal normal
: ---
Assigned To: At-spi maintainer(s)
At-spi maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-10-30 19:40 UTC by Jeremy Bicha
Modified: 2017-10-30 22:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
meson: dist po/meson.build (674 bytes, patch)
2017-10-30 19:40 UTC, Jeremy Bicha 		committed Details | Review

Description Jeremy Bicha 2017-10-30 19:40:08 UTC 
The attached patch is needed to actually build with meson.

I noticed a few other things:

2. The autotools builds installs include files for atspi-device-listener-private.h, atspi-event-listener-private.h, and atspi-private.h. meson doesn't but they are marked private so maybe that's ok for meson.

3. With autotools, the library symlinks are:
libatspi.so -> libatspi.so.0.0.1
libatspi.so.0 -> libatspi.so.0.0.1

But with meson, it's:
libatspi.so -> libatspi.so.0.0.1
libatspi.so.0.0.1 -> libatspi.so.0

I think autotools is more correct.
Comment 1 Jeremy Bicha 2017-10-30 19:40:11 UTC 
Created attachment 362579 [details] [review]
meson: dist po/meson.build
Comment 2 Jeremy Bicha 2017-10-30 19:41:02 UTC 
This is with at-spi-core 2.26.1 on Ubuntu 17.10.
Comment 3 Mike Gorse 2017-10-30 21:15:28 UTC 
Comment on attachment 362579 [details] [review]
meson: dist po/meson.build

Sorry about that. Committed and released a 2.26.2.
And it looks as though I was passing version where soversion should have been passed and vice versa; should be fixed now.
Thanks for the report.
Comment 4 Jeremy Bicha 2017-10-30 22:46:00 UTC 
Thanks, the new release fixes my issues.