After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789397 - Make sure IPP_STATE_IDLE is defined
Make sure IPP_STATE_IDLE is defined
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Printers
git master
Other Linux
: Normal normal
: ---
Assigned To: Marek Kašík
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-10-24 09:58 UTC by Felipe Borges
Modified: 2017-10-24 12:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
printers: Make sure IPP_STATE_IDLE is defined (1001 bytes, patch)
2017-10-24 09:58 UTC, Felipe Borges 		none Details | Review
printers: Make sure IPP_STATE_IDLE is defined (1000 bytes, patch)
2017-10-24 10:35 UTC, Felipe Borges 		committed Details | Review

Description Felipe Borges 2017-10-24 09:58:19 UTC 
.
Comment 1 Felipe Borges 2017-10-24 09:58:44 UTC 
Created attachment 362169 [details] [review]
printers: Make sure IPP_STATE_IDLE is defined

This changes are necessary because we don't require cups >= 1.4,
due to downstreams still shipping old cups versions.

The IPP_STATE_IDLE symbol has been introduced in cups 1.7. The
IPP_IDLE constant has been deprecated.
Comment 2 Marek Kašík 2017-10-24 10:23:39 UTC 
Review of attachment 362169 [details] [review]:

There is a typo in the patch.

::: panels/printers/pp-printer.c
@@ +24,3 @@
 
+#if (CUPS_VERSION_MAJOR == 1) && (CUPS_VERSION_MINOR <= 6)
+#define IPP_STATE_IDDLE IPP_IDLE

A typo.
Comment 3 Felipe Borges 2017-10-24 10:35:24 UTC 
Created attachment 362173 [details] [review]
printers: Make sure IPP_STATE_IDLE is defined

This changes are necessary because we don't require cups >= 1.4,
due to downstreams still shipping old cups versions.

The IPP_STATE_IDLE symbol has been introduced in cups 1.7. The
IPP_IDLE constant has been deprecated.
Comment 4 Marek Kašík 2017-10-24 11:07:09 UTC 
Review of attachment 362173 [details] [review]:

Thank you for the patch. Please push it to the affected branches.
Comment 5 Felipe Borges 2017-10-24 12:16:22 UTC 
Attachment 362173 [details] pushed as 614fb9e - printers: Make sure IPP_STATE_IDLE is defined