GNOME Bugzilla – Bug 789390
mouse pointer hidden incorrectly when it was hidden while outside the terminal
Last modified: 2017-10-28 12:56:49 UTC
I don't feel like investigating this right now, so just filing for safekeeping: Steps to repro in vte-2.91: (0) Move mouse outside over the Find icon in the headerbar. (1) Press space. (If the mouse was inside the terminal, this would hide the pointer.) (2) Press left mouse button to open the search popup. (3) Now move the mouse over the terminal. Results: Mouse pointer is hidden. Expected results: Mouse pointer is visible.
I recently changed the pointer displaying logic, and there are other bugs with this (e.g. regex highlighting still happens under the invisible pointer; it shouldn't). I'll take a look. I'm not sure vte is made aware of mouse movements when a popover is present. E.g. highlighting doesn't work either. I guess the enter/leave state should be brought into the game, the pointer shouldn't be hidden when it has left the widget. Maybe that will cause similar (opposite) bugs to this one, but it's always better to err in the direction of showing the pointer.
Created attachment 362373 [details] [review] Fix This fixes the bug – let's test for a while for regressions / side effects.
Check for the recent change at bug 786441 / commit 3e74409 too. Interestingly, it removed condition that I'm adding back now, just with a different boolean logic. Also, m_mouse_cursor_visible isn't used anywhere else, it should be turned into a local variable. Plus, inverting it ("cursor_invisible") will IMHO make the boolean logic much more readable.
Created attachment 362374 [details] [review] Fix v2 Fix v2 – let's test for a while for regressions / side effects.
Actually, the fix to bug 789536 will almost certainly need that variable. So let's go with the first patch.
Comment on attachment 362373 [details] [review] Fix Alright then. Master and 0-50, please. Thanks!
Done.