After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789327 - appchooserwidget: Don't limit application list unconditionally
appchooserwidget: Don't limit application list unconditionally
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-10-22 22:35 UTC by Florian Müllner
Modified: 2017-10-26 10:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
appchooserwidget: Don't limit application list unconditionally (1.22 KB, patch)
2017-10-22 22:36 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2017-10-22 22:35:55 UTC 
See patch, and bug 732285 for the use case that initiated it.
Comment 1 Florian Müllner 2017-10-22 22:36:01 UTC 
Created attachment 362063 [details] [review]
appchooserwidget: Don't limit application list unconditionally

As documented, GtkAppChooser is "typically [used] for the purpose of
opening a file". However given that applications that support neither
opening files nor URLs are filtered out, the chooser is not actual
useful for any other (atypical) usage. Change that by only applying
the filtering if a content-type was set, and use the full unfiltered
list otherwise.
Comment 2 Matthias Clasen 2017-10-26 03:39:08 UTC 
Review of attachment 362063 [details] [review]:

seems harmless enough
Comment 3 Matthias Clasen 2017-10-26 10:18:21 UTC 
Attachment 362063 [details] pushed as 07beb6d - appchooserwidget: Don't limit application list unconditionally