After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789215 - GtkScrolledWindow and GtkIconView atk objects can cause a segfault on Gjs
GtkScrolledWindow and GtkIconView atk objects can cause a segfault on Gjs
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Accessibility
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-10-19 18:26 UTC by Juan Pablo Ugarte
Modified: 2018-04-22 15:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Test case (806 bytes, text/plain)
2017-10-19 18:26 UTC, Juan Pablo Ugarte 		  Details
Proposed patch: use g_signal_connect_object() (3.53 KB, patch)
2017-10-19 18:30 UTC, Juan Pablo Ugarte 		committed Details | Review
GJS backtrace (6.14 KB, text/plain)
2017-10-19 18:45 UTC, Juan Pablo Ugarte 		  Details

Description Juan Pablo Ugarte 2017-10-19 18:26:40 UTC 
Created attachment 361895 [details]
Test case

GtkScrolledWindow and GtkIconView atk objects use g_signal_connect_data() instead of g_signal_connect_object() relying on the data object to live longer than the source object which is not always true specially garbage collection in GJS.
Comment 1 Juan Pablo Ugarte 2017-10-19 18:30:32 UTC 
Created attachment 361896 [details] [review]
Proposed patch: use g_signal_connect_object()

Simple patch that makes GtkScrolledWindowAccessible and GtkIconViewAccessible use g_signal_connect_object() instead of g_signal_connect_data()
Comment 2 Juan Pablo Ugarte 2017-10-19 18:45:28 UTC 
Created attachment 361900 [details]
GJS backtrace

This is how I originally found this bug