After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789139 - gstavdemux: Whitelist the demuxers required for GC/Wii/WiiU ADPCM streams
gstavdemux: Whitelist the demuxers required for GC/Wii/WiiU ADPCM streams
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
unspecified
Other All
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-10-18 10:08 UTC by Jan Alexander Steffens (heftig)
Modified: 2017-10-19 14:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] gstavdemux: Whitelist the demuxers required for GC/Wii/WiiU ADPCM streams (1.30 KB, patch)
2017-10-18 10:08 UTC, Jan Alexander Steffens (heftig) 		none Details | Review
[PATCH] gstavdemux: Whitelist the demuxers required for GC/Wii/WiiU ADPCM streams (1.96 KB, patch)
2017-10-19 14:16 UTC, Jan Alexander Steffens (heftig) 		committed Details | Review

Description Jan Alexander Steffens (heftig) 2017-10-18 10:08:56 UTC 
Created attachment 361793 [details] [review]
[PATCH] gstavdemux: Whitelist the demuxers required for GC/Wii/WiiU ADPCM streams

Required to play .brstm (GameCube/Wii) and .bfstm (Wii U) files. Needs
at least avdec_adpcm_thp too, but that one is already accessible.
Comment 1 Sebastian Dröge (slomo) 2017-10-19 13:27:20 UTC 
Are proper caps generated for those, and which?
Comment 2 Jan Alexander Steffens (heftig) 2017-10-19 13:29:55 UTC 
0:00:00.027383749 26385 0x55dd241fda30 INFO            GST_TYPEFIND gsttypefind.c:72:gst_type_find_register: registering typefind function for avtype_bfstm
0:00:00.027398258 26385 0x55dd241fda30 INFO            GST_TYPEFIND gsttypefind.c:72:gst_type_find_register: registering typefind function for avtype_brstm


  SINK template: 'sink'
    Availability: Always
    Capabilities:
      application/x-gst-av-bfstm

  SINK template: 'sink'
    Availability: Always
    Capabilities:
      application/x-gst-av-brstm
Comment 3 Sebastian Dröge (slomo) 2017-10-19 13:40:10 UTC 
That should get proper caps then
Comment 4 Jan Alexander Steffens (heftig) 2017-10-19 14:16:29 UTC 
Created attachment 361874 [details] [review]
[PATCH] gstavdemux: Whitelist the demuxers required for GC/Wii/WiiU ADPCM streams

Use audio/x-brstm and audio/x-bfstm for the caps.
Comment 5 Sebastian Dröge (slomo) 2017-10-19 14:51:05 UTC 
commit a771795005fe5ebc06d788a4520e80890685aadc (HEAD -> master)
Author: Jan Alexander Steffens (heftig) <jan.steffens@gmail.com>
Date:   Thu Oct 19 16:15:26 2017 +0200

    avdemux: Whitelist the demuxers required for GC/Wii/WiiU ADPCM streams
    
    Required to play .brstm (GameCube/Wii) and .bfstm (Wii U) files. Needs
    at least avdec_adpcm_thp too, but that one is already accessible.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=789139