After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788738 - Adapt transit route labels in high contrast mode
Adapt transit route labels in high contrast mode
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2017-10-09 20:23 UTC by Marcus Lundblad
Modified: 2017-10-16 19:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
utils: Add function to determine if using high contrast theme (811 bytes, patch)
2017-10-10 19:45 UTC, Marcus Lundblad
committed Details | Review
transitRouteLabel: Override label colors for high contrast mode (1.93 KB, patch)
2017-10-10 19:45 UTC, Marcus Lundblad
none Details | Review
transitRouteLabel: Override label colors for high contrast mode (2.26 KB, patch)
2017-10-11 20:25 UTC, Marcus Lundblad
committed Details | Review

Description Marcus Lundblad 2017-10-09 20:23:45 UTC
The style of icons in the routing sidebar has been changed to used the sidebar icon style (which in the regular theme has non-quite-black dark gray style), and the route label indicator's default color (when not overridden by the transit timetable (GTFS) data) using this same tone. When the high contrast theme is used we should change this color to black and probably disregard colors from the feed (maybe except when there's no route designation, in which case we only show a colored badge which then means the color could be more important).
Comment 1 Marcus Lundblad 2017-10-10 19:45:06 UTC
Created attachment 361284 [details] [review]
utils: Add function to determine if using high contrast theme
Comment 2 Marcus Lundblad 2017-10-10 19:45:19 UTC
Created attachment 361285 [details] [review]
transitRouteLabel: Override label colors for high contrast mode

When in high contrast mode, override colors with high contrasting ones.
Except when there's no actual label, as in this case the color could
be more relevant to show, and there's no text to give contrast to.
Comment 3 Marcus Lundblad 2017-10-11 20:25:54 UTC
Created attachment 361369 [details] [review]
transitRouteLabel: Override label colors for high contrast mode

When in high contrast mode, override colors with high contrasting ones.
Except when there's no actual label, as in this case the color could
be more relevant to show, and there's no text to give contrast to.
Comment 4 Marcus Lundblad 2017-10-16 19:15:10 UTC
Attachment 361284 [details] pushed as bcf110f - utils: Add function to determine if using high contrast theme
Attachment 361369 [details] pushed as a868596 - transitRouteLabel: Override label colors for high contrast mode