After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788720 - opusenc: Allow unpositioned channels.
opusenc: Allow unpositioned channels.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-10-09 14:14 UTC by Mathieu Duponchelle
Modified: 2017-10-11 15:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
opusenc: Allow unpositioned channels. (1.31 KB, patch)
2017-10-09 14:15 UTC, Mathieu Duponchelle 		none Details | Review
opusenc: Allow unpositioned channels. (4.27 KB, patch)
2017-10-10 17:45 UTC, Mathieu Duponchelle 		committed Details | Review

Description Mathieu Duponchelle 2017-10-09 14:14:57 UTC 
The input will be treated as a set of mono channels.
Comment 1 Mathieu Duponchelle 2017-10-09 14:15:01 UTC 
Created attachment 361190 [details] [review]
opusenc: Allow unpositioned channels.
Comment 2 Sebastian Dröge (slomo) 2017-10-09 16:39:01 UTC 
Comment on attachment 361190 [details] [review]
opusenc: Allow unpositioned channels.

Does it generate correct srcpad caps in that case?
Comment 3 Mathieu Duponchelle 2017-10-09 21:12:25 UTC 
(In reply to Sebastian Dröge (slomo) from comment #2)
> Comment on attachment 361190 [details] [review] [review]
> opusenc: Allow unpositioned channels.
> 
> Does it generate correct srcpad caps in that case?

Yes it does, with 5 channels and channel-mask = 0x0, it pushes caps with a stream-count of 5 and a coupled-count of 0, and a channel-mapping <0, 1, 2, 3, 4>, which then gets correctly decoded by opusdec as channels=5, channel-mask=0x37
Comment 4 Sebastian Dröge (slomo) 2017-10-10 07:17:05 UTC 
Yes that's not correct :) It should be channel-mask=0x0 after the decoder too.
Comment 5 Mathieu Duponchelle 2017-10-10 17:45:37 UTC 
Created attachment 361259 [details] [review]
opusenc: Allow unpositioned channels.

The input will be treated as a set of mono channels,
and the channel-mapping-family will be set to 255
(no defined channel meaning)
Comment 6 Mathieu Duponchelle 2017-10-10 17:46:39 UTC 
(In reply to Sebastian Dröge (slomo) from comment #4)
> Yes that's not correct :) It should be channel-mask=0x0 after the decoder
> too.

Fixed, had to make sure channel-mapping-family was set to 255 with unpositioned input :)
Comment 7 Mathieu Duponchelle 2017-10-11 15:43:21 UTC 
Attachment 361259 [details] pushed as 8598f08 - opusenc: Allow unpositioned channels.