After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788606 - Move the icons to the right place
Move the icons to the right place
Status: RESOLVED FIXED
Product: gnome-chess
Classification: Applications
Component: General
git master
Other All
: Normal normal
: ---
Assigned To: gnome-chess-maint
gnome-chess-maint
Depends on:
Blocks:
 
 
Reported: 2017-10-06 15:31 UTC by Mathieu Bridon
Modified: 2017-10-09 12:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Move the icons to the right place (2.94 KB, patch)
2017-10-06 15:31 UTC, Mathieu Bridon
committed Details | Review

Description Mathieu Bridon 2017-10-06 15:31:26 UTC
.
Comment 1 Mathieu Bridon 2017-10-06 15:31:29 UTC
Created attachment 361051 [details] [review]
Move the icons to the right place

This is where the spec says they should go.
Comment 2 Mathieu Bridon 2017-10-06 15:37:49 UTC
Note that the nightly Flatpak build has been broken because of this since September the 5th. :(
Comment 3 Michael Catanzaro 2017-10-06 16:19:39 UTC
Comment on attachment 361051 [details] [review]
Move the icons to the right place

So nobody has been monitoring the nightly builds for at least the past month?

How can you even tell that it is broken, are there build logs available anywhere? It's very relevant since I'm trying to maintain the Epiphany nightlies now and it would be nice to get some notification if a build is failing. Or at the very least, how to check that it's not broken.
Comment 4 Mathieu Bridon 2017-10-06 16:27:59 UTC
At the moment the only notification is a bot in the #flatpak which sends a message when a build fails, for example:

<flatpakbuilder> [ gnome-apps-nightly-master (master) - i386 ] App 'org.gnome.chess' build failed: http://sdkbuilder1.gnome.org//logs/build-2017-10-06-082200/build-gnome-apps-nightly-master-org.gnome.chess-i386.txt

Some of us in the channel monitor those, and try to fix issues and notify the maintainers.

I haven't been doing it since GUADEC, and it seems nobody else has been paying much attention either. :(

It certainly needs some improvement, that's for sure, but it's what we have right now. Eventually, with the move to Gitlab, those builds could probably happen at each merge in master, and notify the maintainers, but we're not there yet.
Comment 5 Mathieu Bridon 2017-10-08 10:34:58 UTC
Attachment 361051 [details] pushed as 813a85c - Move the icons to the right place
Comment 6 Mathieu Bridon 2017-10-08 12:53:35 UTC
I forgot to mention, the build logs are here: http://sdkbuilder.gnome.org/logs/

I pushed this patch, so hopefully there should be an automatic build which succeeds soon.
Comment 7 Sahil Sareen 2017-10-09 12:12:33 UTC
Thanks for this, Mathieu!