After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788580 - HighContrast: .flat buttons become non-flat when their window is :backdropped
HighContrast: .flat buttons become non-flat when their window is :backdropped
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Themes
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-10-06 01:26 UTC by Daniel Boles
Modified: 2017-10-06 01:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot of foreground vs backdrop windows with flat buttons in headerbars (132.50 KB, image/png)
2017-10-06 01:26 UTC, Daniel Boles
  Details
HC: Flat titlebuttons became non-flat in backdrop (12.75 KB, patch)
2017-10-06 01:36 UTC, Daniel Boles
committed Details | Review
HC: Add border/hilight when hovering flat buttons (3.94 KB, patch)
2017-10-06 01:37 UTC, Daniel Boles
committed Details | Review

Description Daniel Boles 2017-10-06 01:26:46 UTC
Created attachment 361013 [details]
screenshot of foreground vs backdrop windows with flat buttons in headerbars

This has always bugged me, but I kept forgetting about it, until apparently my brain decided to make hacking on HC the only thing I can do, and here we are.

This is presumably not intentional as it serves no functional purpose and means that .flat buttons in backdropped windows suddenly jolt to having more contrast than those in the foreground window.
Comment 1 Daniel Boles 2017-10-06 01:36:57 UTC
Created attachment 361014 [details] [review]
HC: Flat titlebuttons became non-flat in backdrop

When the window was backdropped, they suddenly regained their border.
This was clearly not intentional or of any practical use to anyone.

Shuffle around some selectors so that the backdrop ones do not override
the flat ones and make the borders magically reappear when backdropped.

Note that, whereas standard titlebuttons get the border on :hover, other
.flat buttons in the headerbar do not. That should probably be fixed too
Comment 2 Daniel Boles 2017-10-06 01:37:11 UTC
Created attachment 361015 [details] [review]
HC: Add border/hilight when hovering flat buttons

The border and icon highlight are useful feedback that was defeated by
CSS precedence. It worked for .titlebuttons due to their implementation,
but the same was not true for custom .flat buttons. This makes it so.