After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788572 - Fix pipewire version check
Fix pipewire version check
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2017-10-05 19:59 UTC by Florian Müllner
Modified: 2017-10-05 20:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Fetch pipewire micro version (1.31 KB, patch)
2017-10-05 19:59 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2017-10-05 19:59:27 UTC 
See patch
Comment 1 Florian Müllner 2017-10-05 19:59:30 UTC 
Created attachment 360990 [details] [review]
build: Fetch pipewire micro version

Pipewire doesn't export its version defines, so the API checks added
in commit f0c6c4eb1fa2b21e38 effectively disable screencasting, whoops.
Breaking changes like this should disappear once the library stabilizes,
so simply define the version ourselves instead of writing a "proper"
test with AC_COMPILE_IFELSE() ...
Comment 2 Jonas Ådahl 2017-10-05 20:02:47 UTC 
Review of attachment 360990 [details] [review]:

lgtm
Comment 3 Florian Müllner 2017-10-05 20:11:52 UTC 
Attachment 360990 [details] pushed as 18c41ae - build: Fetch pipewire micro version
Comment 4 Jonas Ådahl 2017-10-05 20:17:19 UTC 
Backported to gnome-3-26.