After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788528 - Should not set xml_parser->replaceEntities by hand
Should not set xml_parser->replaceEntities by hand
Status: RESOLVED OBSOLETE
Product: librsvg
Classification: Core
Component: general
2.40.x
Other Linux
: Normal normal
: ---
Assigned To: librsvg maintainers
librsvg maintainers
Depends on:
Blocks:
 
 
Reported: 2017-10-04 18:21 UTC by Federico Mena Quintero
Modified: 2017-12-13 18:29 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Federico Mena Quintero 2017-10-04 18:21:49 UTC
rsvg-base.c:rsvg_set_xml_parse_options() has this:

    /* if false, external entities work, but internal ones don't. if true, internal entities
       work, but external ones don't. favor internal entities, in order to not cause a
       regression */
    xml_parser->replaceEntities = TRUE;

where xml_parser is an xmlParserCtxPtr from libxml2.

We shouldn't be poking into that structure directly.  Instead, we should pass XML_PARSE_NOENT in the options which that function sets.  However, setting that option instead of poking at the structure makes the test suite fail.  This needs investigation.
Comment 1 GNOME Infrastructure Team 2017-12-13 18:29:09 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/librsvg/issues/172.