After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788496 - HighContrast/win32: CSD Windows have missing border and shadows floating above the top corners
HighContrast/win32: CSD Windows have missing border and shadows floating abov...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Themes
3.22.x
Other Windows
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-10-04 08:22 UTC by Daniel Boles
Modified: 2017-10-05 08:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (41.71 KB, image/png)
2017-10-04 08:22 UTC, Daniel Boles
  Details
HighContrast: Correctly select window decoration (4.36 KB, patch)
2017-10-04 23:27 UTC, Daniel Boles
committed Details | Review
screenshot showing results of patch (41.88 KB, image/png)
2017-10-05 08:46 UTC, Daniel Boles
  Details

Description Daniel Boles 2017-10-04 08:22:54 UTC
Created attachment 360894 [details]
screenshot

Running the Inspector on Windows with the HighContrast theme shows that

 * windows do not draw any visible borders, and

 * the top-left and -right corners have a strange shadow that floats around about 40px above and to the side of the real corner of thw dinwo.
Comment 1 Daniel Boles 2017-10-04 23:27:20 UTC
Created attachment 360935 [details] [review]
HighContrast: Correctly select window decoration

We need to do decoration { .window-classes & }, not
decoration.window-classes.

--

This will probably fix *something*... I haven't tested it with all the kinds of
windows yet, though, just opened widget-factory on Mutter and checked that
nothing looked conspicuously different. I'll replicate it on Windows tomorrow.
Comment 2 Daniel Boles 2017-10-05 00:41:47 UTC
Comment on attachment 360935 [details] [review]
HighContrast: Correctly select window decoration

I didn't actually mean to push this the first time, but it seems difficult to argue with. I'll keep this open until I can assess its effect on the reported bug.
Comment 3 Daniel Boles 2017-10-05 08:46:53 UTC
Created attachment 360950 [details]
screenshot showing results of patch

Yup, that seems to handle the main gremlins reported here. Yay!

Next step: tooltips have no border. But that was already an issue... so, on to the next bug.