After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788425 - Use fuzzy TOC matching when querying MusicBrainz
Use fuzzy TOC matching when querying MusicBrainz
Status: RESOLVED OBSOLETE
Product: sound-juicer
Classification: Applications
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Sound Juicer Maintainers
Sound Juicer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-10-02 12:15 UTC by Phillip Wood
Modified: 2021-05-17 16:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add support for multiple parameters in musicbrainz queries (3.76 KB, patch)
2017-10-02 12:15 UTC, Phillip Wood
none Details | Review
MusicBrainz: Use Fuzzy TOC matching (12.80 KB, patch)
2017-10-02 12:15 UTC, Phillip Wood
none Details | Review
Match all media when doing a fuzzy match (9.22 KB, patch)
2017-10-02 12:15 UTC, Phillip Wood
none Details | Review
musicbrainz: Cache release group data (4.15 KB, patch)
2017-10-02 12:15 UTC, Phillip Wood
none Details | Review

Description Phillip Wood 2017-10-02 12:15:28 UTC
This will match albums where the album data is on MusicBrainz but the
discid is not
Comment 1 Phillip Wood 2017-10-02 12:15:33 UTC
Created attachment 360763 [details] [review]
Add support for multiple parameters in musicbrainz queries

This allows us to pass more than just an inc parameter when querying
musicbrainz, which is needed to do fuzzy toc matching.
Comment 2 Phillip Wood 2017-10-02 12:15:38 UTC
Created attachment 360764 [details] [review]
MusicBrainz: Use Fuzzy TOC matching

When searching for the disc on MusicBrainz use fuzzy TOC matching so
that if the discid isn’t found but there is a album with the same
track lengths that is returned. Disable cdstub matches as we cannot
parse them at the moment. The fuzzy match will not have a matching
discid so match track lengths against the disc we’re ripping to find
out which disc in a release matches our disc.
Comment 3 Phillip Wood 2017-10-02 12:15:42 UTC
Created attachment 360765 [details] [review]
Match all media when doing a fuzzy match

This might return two versions of the same album, if so choose the CD
version
Comment 4 Phillip Wood 2017-10-02 12:15:47 UTC
Created attachment 360766 [details] [review]
musicbrainz: Cache release group data

Now that releases are sorted by their release group before querying
them, if two releases are in the same release group we can elide the
second release group query. Also we no longer need to get the release
group id from the release query.
Comment 5 GNOME Infrastructure Team 2021-05-17 16:09:48 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/sound-juicer/-/issues/183.