After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788336 - unattended: Fix target dev name for floppy nodes
unattended: Fix target dev name for floppy nodes
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-09-29 12:58 UTC by Christophe Fergeau
Modified: 2017-10-02 11:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
unattended: Fix target dev name for floppy nodes (1.61 KB, patch)
2017-09-29 12:58 UTC, Christophe Fergeau 		committed Details | Review

Description Christophe Fergeau 2017-09-29 12:58:17 UTC 
The name used for the target dev in libvirt XML is only used for
ordering purpose, and does not necessarily have to be consistent with
how the dev node would be named on a linux box.

Since http://libvirt.org/git/?p=libvirt.git;a=commit;h=5729746543c
(libvirt 3.1.0), libvirt actually forbid using "fd0" for the floppy
target dev name, and defining a domain with such a node returns an
error:
XML error: Unknown disk name 'fd0' and no address specified

This breaks Windows 7 unattended installation.

Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
Comment 1 Christophe Fergeau 2017-09-29 12:58:23 UTC 
Created attachment 360662 [details] [review]
unattended: Fix target dev name for floppy nodes
Comment 2 Felipe Borges 2017-10-02 09:52:08 UTC 
Review of attachment 360662 [details] [review]:

Thanks!

Could you please also push to the gnome-3-26 branch?
Comment 3 Christophe Fergeau 2017-10-02 11:20:42 UTC 
Comment on attachment 360662 [details] [review]
unattended: Fix target dev name for floppy nodes

Committed to master, gnome-3-26 and gnome-3-24.