After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788282 - dialog: Fix setting buttons as initial key focus
dialog: Fix setting buttons as initial key focus
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2017-09-28 10:48 UTC by Florian Müllner
Modified: 2017-10-04 16:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dialog: Fix setting buttons as initial key focus (2.83 KB, patch)
2017-09-28 10:48 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2017-09-28 10:48:24 UTC 
See patch.
Comment 1 Florian Müllner 2017-09-28 10:48:29 UTC 
Created attachment 360591 [details] [review]
dialog: Fix setting buttons as initial key focus

Commit 1c7a3ee61b1892 broke setting the initial key focus for default
buttons added via addButton(). Fix this by allowing the dialog class
to provide a different default widget to ModalDialog than the entire
dialog itself.
Comment 2 David Jordan 2017-09-29 21:05:57 UTC 
I tested this out and was able to configure modal dialogs to provide a default button with initial key focus.
Comment 3 Rui Matos 2017-10-04 14:00:26 UTC 
Review of attachment 360591 [details] [review]:

looks good to me
Comment 4 Florian Müllner 2017-10-04 16:28:19 UTC 
Attachment 360591 [details] pushed as 0b02f75 - dialog: Fix setting buttons as initial key focus