After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788114 - alsasink: Fix Memory leak in payload not succuss case
alsasink: Fix Memory leak in payload not succuss case
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
1.13.x
Other All
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-09-25 05:21 UTC by Ponnam Srinivas
Modified: 2017-09-26 08:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch file attached (822 bytes, patch)
2017-09-25 05:21 UTC, Ponnam Srinivas
none Details | Review
patch file attached (822 bytes, patch)
2017-09-26 08:17 UTC, Ponnam Srinivas
committed Details | Review

Description Ponnam Srinivas 2017-09-25 05:21:04 UTC
Created attachment 360332 [details] [review]
patch file attached

Hi ,
  
  In gst_alsasink_payload , missed buffer unmap in payload failed case.
  code:
  out = gst_buffer_new_and_alloc (framesize);

    gst_buffer_map (buf, &iinfo, GST_MAP_READ);
    gst_buffer_map (out, &oinfo, GST_MAP_WRITE);

    if (!gst_audio_iec61937_payload (iinfo.data, iinfo.size,
            oinfo.data, oinfo.size, &sink->ringbuffer->spec, G_BIG_ENDIAN)) {
      gst_buffer_unref (out);
      return NULL;
    }

    gst_buffer_unmap (buf, &iinfo);
    gst_buffer_unmap (out, &oinfo);
	
   sol: gst_buffer_unmap added 
  Patch attached. Please review and share feedback.
Comment 1 Sebastian Dröge (slomo) 2017-09-26 08:11:38 UTC
Comment on attachment 360332 [details] [review]
patch file attached

Please mark your patch attachments as patch :)
Comment 2 Ponnam Srinivas 2017-09-26 08:17:59 UTC
Created attachment 360411 [details] [review]
patch file attached

patch attached. Please review it
Comment 3 Sebastian Dröge (slomo) 2017-09-26 08:18:36 UTC
commit 0e8a510eda94cacdf2b7f47afd1a387352f09e5b (HEAD -> master)
Author: Ponnam Srinivas <p.srinivas@samsung.com>
Date:   Mon Sep 25 10:42:33 2017 +0530

    alsasink: Fix Memory leak in payload not succuss case
    
    https://bugzilla.gnome.org/show_bug.cgi?id=788114