After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787986 - remoteSearch: Fix remote search providers
remoteSearch: Fix remote search providers
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 788107 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2017-09-21 13:13 UTC by Florian Müllner
Modified: 2017-09-24 22:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
remoteSearch: Fix remote search providers (3.39 KB, patch)
2017-09-21 13:14 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2017-09-21 13:13:58 UTC
See patch.
Comment 1 Florian Müllner 2017-09-21 13:14:04 UTC
Created attachment 360195 [details] [review]
remoteSearch: Fix remote search providers

Commit 289f982949c2 broke all remote providers when adding support for
non-auto-started search providers: Whether the provider should be
auto-started needs to be known in the constructor, so setting the
property on the constructed object doesn't work.
Comment 2 Rui Matos 2017-09-21 14:39:26 UTC
Review of attachment 360195 [details] [review]:

lgtm
Comment 3 Florian Müllner 2017-09-21 14:54:02 UTC
Attachment 360195 [details] pushed as f5a28c2 - remoteSearch: Fix remote search providers
Comment 4 Florian Müllner 2017-09-24 22:39:31 UTC
*** Bug 788107 has been marked as a duplicate of this bug. ***