After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787953 - screen-cast-stream-src: Adjust to pipewire API break
screen-cast-stream-src: Adjust to pipewire API break
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2017-09-20 18:10 UTC by Florian Müllner
Modified: 2017-09-21 16:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screen-cast-stream-src: Adjust to pipewire API break (1.08 KB, patch)
2017-09-20 18:10 UTC, Florian Müllner 		none Details | Review
screen-cast-stream-src: Adjust to pipewire API break (1.08 KB, patch)
2017-09-21 12:56 UTC, Florian Müllner 		committed Details | Review
screen-cast-stream-src: Bump pipewire dependency (1.67 KB, patch)
2017-09-21 12:57 UTC, Florian Müllner 		rejected Details | Review

Description Florian Müllner 2017-09-20 18:10:08 UTC 
Apparently rawhide updated pipewire to 1.5.x which is not API-compatible with 1.4.x ...
Comment 1 Florian Müllner 2017-09-20 18:10:12 UTC 
Created attachment 360147 [details] [review]
screen-cast-stream-src: Adjust to pipewire API break
Comment 2 Florian Müllner 2017-09-21 12:56:43 UTC 
Created attachment 360193 [details] [review]
screen-cast-stream-src: Adjust to pipewire API break

Gah, it was actually a *micro* version bump that broke API ...
Comment 3 Florian Müllner 2017-09-21 12:57:23 UTC 
Created attachment 360194 [details] [review]
screen-cast-stream-src: Bump pipewire dependency

Pipewire changed API between 0.1.4 and 0.1.5, adjust to the change
and require the new version.

This may be a nicer alternative to the previous patch ...
Comment 4 Rui Matos 2017-09-21 14:35:55 UTC 
But upstream seems to be at version 0.1.4.1 :-(
Comment 5 Florian Müllner 2017-09-21 14:52:09 UTC 
https://github.com/PipeWire/pipewire has 0.1.5 ...
Comment 6 Rui Matos 2017-09-21 15:30:13 UTC 
Review of attachment 360193 [details] [review]:

aha! my repo was still pointing at people.freedesktop.org... guess I prefer this one as it's more lenient and the API doesn't seem very stable yet anyway

::: src/backends/meta-screen-cast-stream-src.c
@@ +539,2 @@
   priv->pipewire_remote = pw_remote_new (priv->pipewire_core, NULL);
+#elif PIPEWIRE_VERSION_MICRO  == 5

make this >= 5 though
Comment 7 Florian Müllner 2017-09-21 16:16:28 UTC 
Attachment 360193 [details] pushed as f0c6c4e - screen-cast-stream-src: Adjust to pipewire API break