After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787924 - gst-inspect: Print GstValueArray properties nicely
gst-inspect: Print GstValueArray properties nicely
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal enhancement
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-09-19 22:01 UTC by Mathieu Duponchelle
Modified: 2017-09-22 10:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gst-inspect: Print GstValueArray properties nicely (1.27 KB, patch)
2017-09-19 22:01 UTC, Mathieu Duponchelle 		none Details | Review
gst-inspect: Print GstValueArray properties nicely (1.29 KB, patch)
2017-09-21 22:53 UTC, Mathieu Duponchelle 		accepted-commit_now Details | Review

Description Mathieu Duponchelle 2017-09-19 22:01:02 UTC 
Exact same formatting as GValueArray
Comment 1 Mathieu Duponchelle 2017-09-19 22:01:05 UTC 
Created attachment 360090 [details] [review]
gst-inspect: Print GstValueArray properties nicely
Comment 2 Matthew Waters (ystreet00) 2017-09-20 01:16:25 UTC 
Review of attachment 360090 [details] [review]:

Do we maybe want a slightly different string to differentiate GValueArray and GstValueArray?
Comment 3 Sebastian Dröge (slomo) 2017-09-20 08:29:26 UTC 
Yes that would be useful :)
Comment 4 Mathieu Duponchelle 2017-09-20 20:52:40 UTC 
> Do we maybe want a slightly different string to differentiate GValueArray
> and GstValueArray?

Makes sense, suggestions ? :)
Comment 5 Matthew Waters (ystreet00) 2017-09-21 00:54:39 UTC 
(In reply to Mathieu Duponchelle from comment #4)
> > Do we maybe want a slightly different string to differentiate GValueArray
> > and GstValueArray?
> 
> Makes sense, suggestions ? :)

GStreamer Array of ...
GstValueArray of ...
GstArray of ...
...
Comment 6 Mathieu Duponchelle 2017-09-21 22:53:37 UTC 
Created attachment 360234 [details] [review]
gst-inspect: Print GstValueArray properties nicely
Comment 7 Nicolas Dufresne (ndufresne) 2017-09-22 00:58:42 UTC 
Review of attachment 360234 [details] [review]:

Looks good.
Comment 8 Nicolas Dufresne (ndufresne) 2017-09-22 00:59:13 UTC 
Review of attachment 360234 [details] [review]:

Looks good.
Comment 9 Mathieu Duponchelle 2017-09-22 10:43:44 UTC 
Attachment 360234 [details] pushed as 7da98a2 - gst-inspect: Print GstValueArray properties nicely