GNOME Bugzilla – Bug 787882
[PATCH] Add domain-suffix-match entry in wifi security settings page
Last modified: 2021-06-09 16:32:27 UTC
These patchs follow the change in lr/tls-domain-suffix-match-rh1457542 branch of network-manager-applet project.
Created attachment 360033 [details] [review] wifi: Use GtkGrid for Wi-Fi Security settings page
Created attachment 360034 [details] [review] wifi: Add domain-suffix-match entry domain-suffix-match has been supported in nm-connection-editor for a while. So users can edit that property in nm-connection-editor. But it's still not available in gnome-control-center yet. Fix that by adding domain-suffix-match entry in tls, ttls and peap security settings page.
Review of attachment 360033 [details] [review]: Highly appreciated.
Review of attachment 360034 [details] [review]: What is the use case for this new entry? This needs to be written in the commit message. The code looks good, but I'm not sure how to test it.
Comment on attachment 360033 [details] [review] wifi: Use GtkGrid for Wi-Fi Security settings page Attachment 360033 [details] pushed as 81b68bc - wifi: Use GtkGrid for Wi-Fi Security settings page
Review of attachment 360033 [details] [review]: ::: panels/network/wireless-security/eap-method-ttls.ui @@ +95,3 @@ <property name="visible">True</property> <property name="can_focus">False</property> + <property name="label" translatable="yes">_Inner authentication:</property> Georges, are you sure we want this change?
Created attachment 367495 [details] [review] network: Undo accidentally changed string A colon was added but not spotted on time.
Comment on attachment 367495 [details] [review] network: Undo accidentally changed string Attachment 367495 [details] pushed as dc5bf7e - network: Undo accidentally changed string
(In reply to Georges Basile Stavracas Neto from comment #4) > Review of attachment 360034 [details] [review] [review]: > > What is the use case for this new entry? This needs to be written in the > commit message. The code looks good, but I'm not sure how to test it. As the tooltip suggests, it's suffix of the server certificate name. Basically it's used for identifying the certificate provided by the server while connecting to a WPA&WPA2 Enterprise wireless network to make sure the one communicating with the client is not a fake server.
Friendly ping :-) It would be real neat if we could get this one closed/merged in this unstable window.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new bug report at https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/ Thank you for your understanding and your help.