After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787570 - wayland/inhibit-shortcuts-dialog: Use g_new0 instead of g_new
wayland/inhibit-shortcuts-dialog: Use g_new0 instead of g_new
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: wayland
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2017-09-12 04:21 UTC by Jonas Ådahl
Modified: 2017-09-14 07:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wayland/inhibit-shortcuts-dialog: Use g_new0 instead of g_new (1.16 KB, patch)
2017-09-12 04:21 UTC, Jonas Ådahl 		committed Details | Review

Description Jonas Ådahl 2017-09-12 04:21:52 UTC 
This makes the dialog actually show reliably.
Comment 1 Jonas Ådahl 2017-09-12 04:21:56 UTC 
Created attachment 359568 [details] [review]
wayland/inhibit-shortcuts-dialog: Use g_new0 instead of g_new

The code assumed the newly allocated blocked was initialized to 0, but
it wasn't since g_new was used. Fix that by using g_new0.
Comment 2 Olivier Fourdan 2017-09-12 08:45:09 UTC 
Review of attachment 359568 [details] [review]:

Yes, that was an oversight.
Comment 3 Olivier Fourdan 2017-09-14 07:35:31 UTC 
Comment on attachment 359568 [details] [review]
wayland/inhibit-shortcuts-dialog: Use g_new0 instead of g_new

attachment 359568 [details] [review] pushed to git master as commit 07f6c85 - wayland/inhibit-shortcuts-dialog: Use g_new0 instead of g_new