GNOME Bugzilla – Bug 787402
3.25.92: gdb plugin fails to build on mips
Last modified: 2017-09-07 19:16:41 UTC
gnome-builder 3.25.92 Debian unstable It looks like you added a new gdb plugin to gnome-builder 3.25.92 (after 3.25.91). This is now causing gnome-builder to fail to build on mips* architectures. Full build logs are at: https://buildd.debian.org/status/package.php?p=gnome-builder (You can click Build Attempted or Installed in the status chart to see the full log). Build log excerpt ================= 507/697] cc -Iplugins/gdb/gdb-plugin@sha -Iplugins/gdb -Ilibide -I../plugins/gdb -I../libide -Isubprojects/libgd -I../subprojects/libgd -I/usr/include/libpeas-1.0 -I/usr/include/gobject-introspection-1.0 -I/usr/include/glib-2.0 -I/usr/lib/mips-linux-gnu/glib-2.0/include -I/usr/include/libdazzle-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/mips-linux-gnu/dbus-1.0/include -I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/gtksourceview-3.0 -I/usr/include/libxml2 -I/usr/include/template-glib-1.0 -I/usr/include/json-glib-1.0 -I/usr/include/jsonrpc-glib-1.0 -I/<<PKGBUILDDIR>>/obj-mips-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu11 -Wcast-align -Wdeclaration-after-statement -Werror=format-security -Werror=format=2 -Wformat-nonliteral -Wformat-security -Wmissing-include-dirs -Wnested-externs -Wno-missing-field-initializers -Wno-sign-compare -Wno-strict-aliasing -Wno-uninitialized -Wno-unused-parameter -Wpointer-arith -Wredundant-decls -Wshadow -Wswitch-default -Wswitch-enum -Wundef -DHAVE_CONFIG_H -D_GNU_SOURCE -DIDE_COMPILATION -DG_DISABLE_CAST_CHECKS -DG_DISABLE_ASSERT -DG_DISABLE_CHECKS -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -DLIBGD_TAGGED_ENTRY=1 -MMD -MQ 'plugins/gdb/gdb-plugin@sha/gbp-gdb-plugin.c.o' -MF 'plugins/gdb/gdb-plugin@sha/gbp-gdb-plugin.c.o.d' -o 'plugins/gdb/gdb-plugin@sha/gbp-gdb-plugin.c.o' -c ../plugins/gdb/gbp-gdb-plugin.c In file included from ../plugins/gdb/gbp-gdb-debugger.h:23:0, from ../plugins/gdb/gbp-gdb-plugin.c:21: ../plugins/gdb/gdbwire.h:1208:6: warning: redundant redeclaration of ‘gdbwire_mi_output_free’ [-Wredundant-decls] void gdbwire_mi_output_free(struct gdbwire_mi_output *param); ^~~~~~~~~~~~~~~~~~~~~~ ../plugins/gdb/gdbwire.h:1180:6: note: previous declaration of ‘gdbwire_mi_output_free’ was here void gdbwire_mi_output_free(struct gdbwire_mi_output *param); ^~~~~~~~~~~~~~~~~~~~~~ [508/697] cc -Iplugins/gdb/gdb-plugin@sha -Iplugins/gdb -Ilibide -I../plugins/gdb -I../libide -Isubprojects/libgd -I../subprojects/libgd -I/usr/include/libpeas-1.0 -I/usr/include/gobject-introspection-1.0 -I/usr/include/glib-2.0 -I/usr/lib/mips-linux-gnu/glib-2.0/include -I/usr/include/libdazzle-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/mips-linux-gnu/dbus-1.0/include -I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/gtksourceview-3.0 -I/usr/include/libxml2 -I/usr/include/template-glib-1.0 -I/usr/include/json-glib-1.0 -I/usr/include/jsonrpc-glib-1.0 -I/<<PKGBUILDDIR>>/obj-mips-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu11 -Wcast-align -Wdeclaration-after-statement -Werror=format-security -Werror=format=2 -Wformat-nonliteral -Wformat-security -Wmissing-include-dirs -Wnested-externs -Wno-missing-field-initializers -Wno-sign-compare -Wno-strict-aliasing -Wno-uninitialized -Wno-unused-parameter -Wpointer-arith -Wredundant-decls -Wshadow -Wswitch-default -Wswitch-enum -Wundef -DHAVE_CONFIG_H -D_GNU_SOURCE -DIDE_COMPILATION -DG_DISABLE_CAST_CHECKS -DG_DISABLE_ASSERT -DG_DISABLE_CHECKS -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -DLIBGD_TAGGED_ENTRY=1 -MMD -MQ 'plugins/gdb/gdb-plugin@sha/gdbwire.c.o' -MF 'plugins/gdb/gdb-plugin@sha/gdbwire.c.o.d' -o 'plugins/gdb/gdb-plugin@sha/gdbwire.c.o' -c ../plugins/gdb/gdbwire.c FAILED: plugins/gdb/gdb-plugin@sha/gdbwire.c.o cc -Iplugins/gdb/gdb-plugin@sha -Iplugins/gdb -Ilibide -I../plugins/gdb -I../libide -Isubprojects/libgd -I../subprojects/libgd -I/usr/include/libpeas-1.0 -I/usr/include/gobject-introspection-1.0 -I/usr/include/glib-2.0 -I/usr/lib/mips-linux-gnu/glib-2.0/include -I/usr/include/libdazzle-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/mips-linux-gnu/dbus-1.0/include -I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/gtksourceview-3.0 -I/usr/include/libxml2 -I/usr/include/template-glib-1.0 -I/usr/include/json-glib-1.0 -I/usr/include/jsonrpc-glib-1.0 -I/<<PKGBUILDDIR>>/obj-mips-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu11 -Wcast-align -Wdeclaration-after-statement -Werror=format-security -Werror=format=2 -Wformat-nonliteral -Wformat-security -Wmissing-include-dirs -Wnested-externs -Wno-missing-field-initializers -Wno-sign-compare -Wno-strict-aliasing -Wno-uninitialized -Wno-unused-parameter -Wpointer-arith -Wredundant-decls -Wshadow -Wswitch-default -Wswitch-enum -Wundef -DHAVE_CONFIG_H -D_GNU_SOURCE -DIDE_COMPILATION -DG_DISABLE_CAST_CHECKS -DG_DISABLE_ASSERT -DG_DISABLE_CHECKS -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -DLIBGD_TAGGED_ENTRY=1 -MMD -MQ 'plugins/gdb/gdb-plugin@sha/gdbwire.c.o' -MF 'plugins/gdb/gdb-plugin@sha/gdbwire.c.o.d' -o 'plugins/gdb/gdb-plugin@sha/gdbwire.c.o' -c ../plugins/gdb/gdbwire.c ../plugins/gdb/gdbwire.c:1688:24: error: expected identifier or ‘(’ before numeric constant gdbwire_mi_pstate *mips; ^ ../plugins/gdb/gdbwire.c: In function ‘gdbwire_mi_parser_create’: ../plugins/gdb/gdbwire.c:1719:13: error: expected identifier before numeric constant parser->mips = gdbwire_mi_pstate_new();
Interesting, it looks like "mips" is a reserved keyword on mips? We use an amalgamation of gdbwire from upstream (no releases or anything yet). I'll put a quick patch together and regen the amalgamation and see if we can get it fixed upstream too.
Created attachment 359374 [details] [review] gdb: avoid use of mips mips is an integer constant on GCC/mips. So we need ot be careful to not use it here.
Attachment 359374 [details] pushed as 723a5d4 - gdb: avoid use of mips