After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787272 - [Patch] Migrate from intltool to gettext
[Patch] Migrate from intltool to gettext
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks: 763587 785151
 
 
Reported: 2017-09-04 22:20 UTC by Niels De Graef
Modified: 2017-09-12 09:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[Patch] Migrate from intltool to gettext (8.77 KB, patch)
2017-09-04 22:20 UTC, Niels De Graef 		none Details | Review
Migrate from intltool to gettext (8.87 KB, patch)
2017-09-12 08:25 UTC, Marinus Schraal 		none Details | Review
Migrate from intltool to gettext (8.87 KB, patch)
2017-09-12 09:25 UTC, Marinus Schraal 		committed Details | Review

Description Niels De Graef 2017-09-04 22:20:21 UTC 
Created attachment 359114 [details] [review]
[Patch] Migrate from intltool to gettext

Intltool is deprecated and should no longer be used. There is also [1] to encourage dropping it in GNOME tooling, in favor of GNU gettext.

Attached is a patch to perform the migration.



[1] https://wiki.gnome.org/Initiatives/GnomeGoals/GettextMigration
Comment 1 Marinus Schraal 2017-09-12 08:25:41 UTC 
Created attachment 359584 [details] [review]
Migrate from intltool to gettext

Signed-off-by: Niels De Graef <nielsdegraef@gmail.com>
Comment 2 Marinus Schraal 2017-09-12 09:25:32 UTC 
Created attachment 359587 [details] [review]
Migrate from intltool to gettext

Signed-off-by: Niels De Graef <nielsdegraef@gmail.com>
Comment 3 Niels De Graef 2017-09-12 09:33:52 UTC 
Marinus, just saw you committed this, so wanted to give you a quick update:

COPYRIGHT_HOLDER should be set to "GNOME Music contributors"
Comment 4 Marinus Schraal 2017-09-12 09:40:34 UTC 
(In reply to Niels De Graef from comment #3)
> Marinus, just saw you committed this, so wanted to give you a quick update:
> 
> COPYRIGHT_HOLDER should be set to "GNOME Music contributors"

Thanks & done.

Thanks for the initial patch as well, much appreciated.

Two things I ran into/noticed/fixed (after taking more time than I care to admit):

* appdata_XML -> appdata_DATA
* appdata statement ordering

Fixed in master.