After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787254 - rtph265depay: P-frames are being marked as I-frames
rtph265depay: P-frames are being marked as I-frames
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.12.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-09-04 13:52 UTC by Patrick Radizi
Modified: 2017-09-05 13:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
rtph265depay: fix keyunit detection (1.48 KB, patch)
2017-09-05 11:59 UTC, Tim-Philipp Müller
committed Details | Review

Description Patrick Radizi 2017-09-04 13:52:13 UTC
The rtph265depay element incorrectly interprets a large number of different nal unit types as IDR units and un-sets the GST_BUFFER_FLAG_DELTA_UNIT flag. 

It is the macro NAL_TYPE_IS_KEY that is broken.
Comment 1 Sebastian Dröge (slomo) 2017-09-05 07:33:09 UTC
This should also be checked in h265parse then, to make sure that it is not broken in the same way.
Comment 2 Tim-Philipp Müller 2017-09-05 11:59:23 UTC
Created attachment 359180 [details] [review]
rtph265depay: fix keyunit detection
Comment 3 Tim-Philipp Müller 2017-09-05 13:03:19 UTC
commit 6f9cb1716a008bcc155205ca00df4c3d750d8f67
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Tue Sep 5 12:56:44 2017 +0100

    rtph265depay: fix keyunit detection
    
    https://bugzilla.gnome.org/show_bug.cgi?id=787254