After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787059 - rtsp-server : Fix Memory leak isse in rtsp-sdp.c
rtsp-server : Fix Memory leak isse in rtsp-sdp.c
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
1.12.2
Other All
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-08-31 07:59 UTC by Satya Prakash Gupta
Modified: 2017-08-31 10:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch is attched (769 bytes, patch)
2017-08-31 07:59 UTC, Satya Prakash Gupta 		committed Details | Review

Description Satya Prakash Gupta 2017-08-31 07:59:18 UTC 
Created attachment 358820 [details] [review]
Patch is attched

Hi,

File : gst-rtsp-server/gst/rtsp-server/rtsp-sdp.c

Function  mikey_add_crypto_sessions  Line : 128

There is memory leak in rtsp-sdp.c file as memory is at gst_rtsp_stream_get_srtp_encoder but did not unref in error case.

Solution :  gst_object_unref (encoder);

++patch is attched for possible solution.

Kindly review the patch and provide your feedback.
Comment 1 Tim-Philipp Müller 2017-08-31 10:04:53 UTC 
Thanks.

commit d690fbd37dccbc7970529ad41bcf633282c09c78 
Author: Satya Prakash Gupta <sp.gupta@samsung.com>
Date:   Thu Aug 31 13:24:15 2017 +0530

    sdp: fix Memory leak in error case
    
    https://bugzilla.gnome.org/show_bug.cgi?id=787059