GNOME Bugzilla – Bug 786956
EmojiChooser: Fix theming on Adwaita:dark, HighContrast, etc.
Last modified: 2017-09-04 15:23:31 UTC
Created attachment 358653 [details] emoji selector (image) The Emoji list have dark text on Black theme. Please see the attached screenshot. Thanks
pretty sure thats a theme issue
I think it'd be more correct to have the unselected buttons use a dim fg colour, like .dim-label, not the borders colour; they are not borders after all, and the borders colour is already a bit too dim for its intended purpose if you ask me.
The current styling would've happened to work on Adwaita light, where bgcolor < borders < fgcolor, but it doesn't on :dark, where borders < bgcolor < fgcolor.
Created attachment 358982 [details] [review] Adwaita: Make use of SASS syntax for emoji stuff This makes the theme easier to maintain.
Created attachment 358983 [details] [review] Adwaita: Actually mix colours for emoji button Apparently a decimal does not work, so sassc seemed to treat it as a %, so it ended up way too low. Using % fixes that, as used elsewhere anyway
Created attachment 358984 [details] [review] Adwaita: proper colours for inactive emoji buttons Use opacity to differentiate unselected/hovered/selected buttons. It had assumed bg < border < fg colours, which may be false, as in Adwaita:dark This also means we do not need to special-case for the backdrop state.
Created attachment 358985 [details] [review] Adwaita: Apply opacity to emoji button label only This avoids diluting the colour of the bottom border shown on hover.
I'm also looking at porting the Adwaita styles to HighContrast, though it seems that when backdropped, the emoji buttons magically regain their inherited borders, so the size-request of the chooser changes. Simply applying all selectors to blah, blah:backdrop {} of course resolves this, but that feels a bit too blunt-force.
Created attachment 358986 [details] [review] HighContrast: basic port of emoji CSS from Adwaita
In case it's easier, I've pushed these as a WIP branch: https://git.gnome.org/browse/gtk+/log/?h=wip/dboles/emoji-css