GNOME Bugzilla – Bug 786801
fwupd: -Denable-dell=false needs -Denable-synatpics=false
Last modified: 2017-08-29 01:03:02 UTC
Otherwise we fail to configure with 'compiling --enable-synaptics requires --enable-dell'.
Created attachment 358591 [details] [review] core-deps-3.26: disable synaptics in fwupd If synaptic is enabled, it also requires dell enabled. Looks like synaptic is enabled somehow, so either we set "-Denable-dell=false" too or we set "-Denable-dell=true" and provide the required dependencies: "efivar", "libsmbios" and "fwup". fwupd is a dependency for only gnome-software and I don't know how the absence of synaptics affects them, but see attached diff to disable synaptics.
Comment on attachment 358591 [details] [review] core-deps-3.26: disable synaptics in fwupd You added -Denable-dell=false yourself in https://git.gnome.org/browse/jhbuild/commit/?id=2d629176c557b8a3335d19a7bb096528746b1c49. Indeed, there are still missing dependencies.
Ups, I got it wrong in the title, I think. "-Denable-dell=false" needs "-Denable-synatpics=false". The latter is "true" by default, hence the brokeness. Sorry for the confusion.
Oops. In my comment above, I said 'so either we set "-Denable-dell=false" too' but I meant 'so either we set "-Denable-synaptics=false" too' As Michael Catanzaro mentioned, I pushed "-Denable-dell=false", so obviously I know it's currently disabled. So, which way we go: disable synaptics or enable dell + add its deps ?
Either way would be fine.
I suspect Mario might have an opinion ;)
Thanks for adding me. Yes, I would prefer to see libsmbios + -enable-dell=true land in jhbuild. The Dell plugin not only allows flashing/using Dell TPMs and docks but will also enable other plugins (such as Synaptics and Thunderbolt) to have additional functionality on Dell platforms. It's a better and more cohesive experience if you can have it enabled.
I'd be astounded if anyone is foolish enough to use jhbuild to update their firmware. Let's just make fwupd build, one way or the other. If you want to add the new dependencies, then enabling new features is fine. Otherwise it needs to be disabled.
Created attachment 358633 [details] [review] 3.26: add fwupdate as dependency of fwupd I attached a diff file that adds fwupdate (from Red Hat Bootloader Team; it provides fwup) to sysdeps, as it has some build specificities that make harder to build in JHBuild (e.g. requires passing to Makefile a EFIVAR variable set with a value specific for the Linux distribution). I didn't add efivar and smbios because fwupdate depends on them - at least for debian, archlinux, fedora and CentOS (unable to find pkg info for RedHat). So hopefully it should be enough. Arch Linux works. Tests for other distributions are welcome.
Review of attachment 358633 [details] [review]: ::: modulesets/gnome-sysdeps-3.26.modules @@ +245,3 @@ + </systemmodule> + + <systemmodule id="fwupdate-devel"> I don't understand the split between fwupdate and fwupdate-devel. Is the .pc file not in the -devel package on Fedora?
I don't think running jhbuild for updating your firmware is risky. fwupd has a very thorough exercised test suite and every commit runs through a battery of tests on Travis CI. At least with UEFI the main (dangerous) parts of system firmware flashing don't actually run in Linux, but rather in UEFI and are provided by the vendor via a UEFI UpdateCapsule routine. The Linux side of it is mostly parsing the ESRT and how it's presented to the OS.
Created attachment 358637 [details] [review] 3.26: add fwupdate as dependency of fwupd Fedora seems to have both fwupdate and fwupdate-devel packages [1], but a new test made me believe that the we only need fwupdate-devel - which by the way is the one that has pkg-config files (error in my previous diff). This newly attached diff includes only "fwupdate" looking for pkg-config files. In Fedora, it should actually install fwupdate-devel package. [1] https://apps.fedoraproject.org/packages/fwupdate-devel/
Review of attachment 358637 [details] [review]: yes
While changing this why not also turn enable-uefi to true? It will make it more useful now that you have the depends in place.
If all the dependencies are there now, then that seems fine. Thanks Rafael and Mario!
Review of attachment 358637 [details] [review]: I pushed the approved patch, also setting -Denable-uefi=true as it only requires 'fwup'. commit e4528807d09df33e1ecab6a0e268e7a0bfcbe0db