After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786684 - Control center window resizes when sound panel is opened
Control center window resizes when sound panel is opened
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Sound
git master
Other Linux
: Normal normal
: ---
Assigned To: Control center sound maintainer(s)
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-08-23 14:33 UTC by Allan Day
Modified: 2018-01-09 15:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot-sound-applications-tab-full (119.21 KB, image/png)
2018-01-04 14:34 UTC, Felipe Borges
  Details
sound: Embed the "Applications" tab content in a scrolled window (1.63 KB, patch)
2018-01-04 14:35 UTC, Felipe Borges
none Details | Review
scrollbar on top of the switch (80.58 KB, image/png)
2018-01-09 12:27 UTC, Bastien Nocera
  Details
sound: Embed the "Applications" tab content in a scrolled window (2.03 KB, patch)
2018-01-09 15:34 UTC, Felipe Borges
committed Details | Review

Description Allan Day 2017-08-23 14:33:14 UTC
With the new gnome-control-center shell, the window is resizable. Unfortunately, when the sound panel is opened, the window's size changes - on my system it jumps from being 687px tall to become 952px tall.

This is quite a sudden and dramatic change - it's unpleasant and surprising and is inconsistent with how windows are supposed to behave.
Comment 1 Bastien Nocera 2017-08-23 15:09:38 UTC
I don't think this is easily solvable without 1) a minimum width/height for all panels 2) a redesign of the sound panel.

Adding scrollbars to the sound panel would just be lipstick on a pig at this point.
Comment 2 Allan Day 2017-08-23 15:36:44 UTC
(In reply to Bastien Nocera from comment #1)
...
> Adding scrollbars to the sound panel would just be lipstick on a pig at this
> point.

Might be worth it as a short-term fix. This bug isn't nice.
Comment 3 Felipe Borges 2018-01-04 14:34:35 UTC
Created attachment 366301 [details]
screenshot-sound-applications-tab-full

I have experienced something similar today. The culprit seems to be epiphany having entries for each tab playing sound in the "Applications" list. See screenshot.
Comment 4 Felipe Borges 2018-01-04 14:35:02 UTC
Created attachment 366302 [details] [review]
sound: Embed the "Applications" tab content in a scrolled window

The "Applications" tab might expand vertically indefinitely depending
on the amount of applications playing sounds simultaneously. This
causes the whole Control Center window to grow vertically.

These changes pack the content of the "Applications" tab in a
GtkScrolledWindow.
Comment 5 Bastien Nocera 2018-01-09 12:27:23 UTC
Created attachment 366546 [details]
scrollbar on top of the switch

The scrollbar ends up on top of the switches, which really doesn't look that good. Looks sound other than that.

Please also add a reproducer in the commit message. I used gst-play-1.0:
1. Launch "gst-play-1.0 <music file>"
2. Press space to pause the playback
3. Press Ctrl+Z to send it into the background
4. Goto 1.
Comment 6 Bastien Nocera 2018-01-09 12:27:58 UTC
Review of attachment 366302 [details] [review]:

As per comment 5.
Comment 7 Felipe Borges 2018-01-09 15:34:04 UTC
Created attachment 366558 [details] [review]
sound: Embed the "Applications" tab content in a scrolled window

The "Applications" tab might expand vertically indefinitely depending
on the amount of applications playing sounds simultaneously. This
causes the whole Control Center window to grow vertically.

To reproduce the issue you'd need to launch multiple sound sources.
  1. Launch "gst-play-1.0 <music file>"
  2. Press space to pause the playback
  3. Press Ctrl+Z to send it into the background
  4. Goto 1.

These changes pack the content of the "Applications" tab in a
GtkScrolledWindow.

To avoid having the scrollbar overlapping the switchers, we set a
10px margin-end to the inner container.
Comment 8 Felipe Borges 2018-01-09 15:49:10 UTC
Attachment 366558 [details] pushed as b3d51d9 - sound: Embed the "Applications" tab content in a scrolled window