GNOME Bugzilla – Bug 786662
Fix Bluetooth connections in the new Network panel
Last modified: 2017-08-23 13:17:56 UTC
Bluetooth connections show in the Network panel, but its layout is inconsistent with the rest of the panel. The patches below temporarily fix that until we move Bluetooth connections to the new Mobile Broadband panel. (In my defense, I didn't have the hardware to see these connections until 10 days ago)
Created attachment 358195 [details] [review] network: Show simple devices in an isolated section As a temporary solution until we don't have the Mobile Broadband panel, the Network panel should take care of simple devices such as Bluetooth and metered connections, and should do so in such a way that is consistent with how the rest of devices is managed. Currently, however, NetDeviceSimple objects still present the old, grid-based layout, breaking the expectations and completely destroying the consistency of the panel This patch moves simple devices to a section of its own. The next patch will update the visuals to match the other devices.
Created attachment 358196 [details] [review] network: Update NetDeviceSimple layout Following the previous commit, this patch adapts the NetDeviceSimple layout to be consistent with the other devices in the Network panel. This is, however, a temporary solution, for simple devices will be handled in a separate panel in the future.
Review of attachment 358195 [details] [review]: ok
Review of attachment 358196 [details] [review]: lgtm ::: panels/network/net-device-simple.c @@ +48,3 @@ + GtkWidget *widget; + + /* add widgets to size group */ this comment doesn't make sense @@ -50,3 @@ NetDeviceSimple *device_simple = NET_DEVICE_SIMPLE (object); /* add widgets to size group */ comment should go too
Attachment 358195 [details] pushed as d5de1d2 - network: Show simple devices in an isolated section Attachment 358196 [details] pushed as 4922f37 - network: Update NetDeviceSimple layout