GNOME Bugzilla – Bug 786650
the control to enable file sharing is on the left
Last modified: 2021-06-09 16:27:36 UTC
Using g-c-c 3.25.90, the file sharing screen has is on/off control on the left of the headerbar, other panels have their control on the right, wouldn't it make sense to have that consistent?
They've been on the left for a couple of years, as this screenshot shows: http://www.hadess.net/2014/06/firewalls-and-per-network-sharing.html I'm pretty certain that was to avoid the dialogues becoming too big and cramped, with the toggle and close button to the right.
I agree that the switch placement doesn't look all that great. However, Bastien is also correct that the dialog width would make it difficult to move them. Ideally we'd give these dialogs a general revamp - they don't look all that great. Regarding the switch, one option might be to move it into the dialog, like we do for Privacy > Location Services.
Created attachment 358324 [details] [review] sharing: Move the "Remote Login" dialog Switch into the dialog
Created attachment 358325 [details] remote-login-dialog-screenshot This is how it looks like in comparison to what it used to be.
Review of attachment 358324 [details] [review]: One comment, if that's the way we want to proceed. ::: panels/sharing/sharing.ui @@ +481,2 @@ <child> + <object class="GtkListBox"> This could be just a regular container (GtkBox?) with the "view" style class applied.
Created attachment 367328 [details] [review] sharing: Move the "Remote Login" dialog Switch into the dialog
Review of attachment 367328 [details] [review]: Looks good, thanks!
Attachment 367328 [details] pushed as 5796d83 - sharing: Move the "Remote Login" dialog Switch into the dialog
I didn't mean to close this bug. Reopening for the other dialogs.
Created attachment 367688 [details] [review] sharing: Tweak the File Sharing Dialog UI Move the File Sharing switch into the dialog, reposition the sections order, and change the remember password entry to a check button. These changes are according to the mockups available at https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/ master/system-settings/sharing/file-sharing.png
Created attachment 367689 [details] file-sharing-dialog-screenshot
Created attachment 367690 [details] [review] sharing: Place "Media Sharing" switch into dialog
Created attachment 367694 [details] [review] sharing: Place "Screen Sharing" switch into dialog
Created attachment 367695 [details] [review] universal-access: Style "Sound Keys" as a row
Created attachment 367719 [details] [review] universal-access: Use header bar in Cursor Size dialog We are using headerbars everywhere.
Created attachment 367720 [details] [review] universal-access: Style "Visual Alerts" row in dialog
Created attachment 367721 [details] [review] universal-access: Move "Repeat Keys" switch into dialog
Created attachment 367722 [details] [review] universal-access: Move "Cursor Blinking" switch into dialog
Created attachment 367723 [details] [review] privacy: Style "Automatic Problem Report" as a row
Review of attachment 367688 [details] [review]: Looks alright, but the different sections make it look even weirder than it was. I think that might be one for later...
Review of attachment 367688 [details] [review]: ::: panels/sharing/sharing.ui @@ +418,3 @@ + <property name="visible">True</property> + <property name="xalign">0</property> + <property name="label" translatable="yes">Networks on which to share music, pictures and videos.</property> And that's definitely wrong. That's the label from the media sharing. File sharing is to share files...
Review of attachment 367690 [details] [review]: Looks weird as well, but better.
Review of attachment 367694 [details] [review]: Can't test this one under Wayland, but I'm going to assume it's the same as for the Media sharing panel.
Review of attachment 367695 [details] [review]: Sure.
Review of attachment 367719 [details] [review]: Seems weird, but sure.
Review of attachment 367720 [details] [review]: I'd really like the section below to also be in a similar row, but that's fine for a first pass.
Review of attachment 367721 [details] [review]: Delay and Speed also need to be in their own row, see the Mouse panel for examples.
Review of attachment 367722 [details] [review]: Ditto for this slider.
Review of attachment 367723 [details] [review]: Sure.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new bug report at https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/ Thank you for your understanding and your help.