GNOME Bugzilla – Bug 786580
gdesktopappinfo.c: Add Tilix as a fallback terminal
Last modified: 2017-11-27 18:50:59 UTC
Created attachment 358093 [details] [review] patch Currently g_app_info_create_from_commandline tries to open gnome-terminal, and then fallsback on nxterm, color-xterm, rxvt, xterm, dtterm and xterm again. With this patch it attempts to use tilix before falling back to xterm. Note this commit replaces a xterm reference with tilix, but it's not removing xterm as a fallback due to be being fallen back on again a few lines down.
Review of attachment 358093 [details] [review]: I’m wary of this turning into a list of every terminal application under the sun. Currently, the list includes terminals which distributions are likely to have installed by default. As much as I think Tilix is a cool terminal emulator, I don’t believe it’s installed by any distros by default yet, and it’s even less likely that it’s going to be installed on a system where gnome-terminal isn’t (and hence gnome-terminal will always get picked first by the code). For that reason, I’m not accepting this. If Tilix is installed by default on distros in future, I’ll be happy to revisit this patch then. :-) Similarly, if any distros want to carry this as a custom patch in case they want to ship Tilix, that’s something they can certainly do.
See also: https://bugzilla.gnome.org/show_bug.cgi?id=627943#c31
Created attachment 358265 [details] [review] drop xterm check
(In reply to Philip Withnall from comment #1) > Review of attachment 358093 [details] [review] [review]: > > I’m wary of this turning into a list of every terminal application under the > sun. Currently, the list includes terminals which distributions are likely > to have installed by default. As much as I think Tilix is a cool terminal > emulator, I don’t believe it’s installed by any distros by default yet, and > it’s even less likely that it’s going to be installed on a system where > gnome-terminal isn’t (and hence gnome-terminal will always get picked first > by the code). > > For that reason, I’m not accepting this. If Tilix is installed by default on > distros in future, I’ll be happy to revisit this patch then. :-) Similarly, > if any distros want to carry this as a custom patch in case they want to > ship Tilix, that’s something they can certainly do. I'm using Arch, without any of the current list but I can understand that it's a rare case. I've added another patch that drops the check for xterm as you use it even if it's not there. (In reply to Emmanuele Bassi (:ebassi) from comment #2) > See also: https://bugzilla.gnome.org/show_bug.cgi?id=627943#c31 Seeing as the the other bug has been open 7 years there is obviously nothing I can add to it. I hope one day there will be a config in $XDG_CONFIG_HOME for a default terminal, it makes sense. I've used the link suggestion from the other bug as well, it's a shitty, fix but it works.
Review of attachment 358265 [details] [review]: That’ll do. Thanks.
(In reply to Cj Malone from comment #4) > (In reply to Emmanuele Bassi (:ebassi) from comment #2) > > See also: https://bugzilla.gnome.org/show_bug.cgi?id=627943#c31 > > Seeing as the the other bug has been open 7 years there is obviously nothing > I can add to it. I hope one day there will be a config in $XDG_CONFIG_HOME > for a default terminal, it makes sense. One of the problems of not having enough developers to fix every bug; sorry. It’ll get fixed eventually. If you want to have a shot at fixing it with the approach in comment #31, I’ll be happy to review.
See bug #790914 for a follow-up fix which was needed for build machines (such as distro package builders) as a result of this change.