GNOME Bugzilla – Bug 786572
installed-tests failure with gjs 1.49.90 on Ubuntu
Last modified: 2017-10-03 01:31:27 UTC
Ubuntu 17.10's autopkgtests for gjs 1.49.90 (just uploaded today) have one failed test. not ok 24 Introspected GObject resolves properties when they are shadowed by methods # Message: Expected undefined to equal 42. # Stack: # @/usr/lib/gjs/gjs/installed-tests/js/testEverythingEncapsulated.js:241:9 JS G OBJ: Defining method set_bare in prototype for RegressTestObj (Regress.TestObj) ok 25 Introspected function length skips over instance parameters of methods http://autopkgtest.ubuntu.com/packages/g/gjs/artful/amd64 Ubuntu's mozjs52 is a few weeks old and might not have all the patches that you have in your tree.
This test is testing the code added in commit 40b7b1767dcd5176d3c493cb02e2a3ff1fca7eae. For once, it seems unlikely that mozjs is the culprit. Does anything in that commit seem suspicious to you?
Subsequent versions seem to have passed their tests OK, is this still relevant?
Yes, it's still an issue. The tests only pass because I disabled this test. https://anonscm.debian.org/viewvc/pkg-gnome/desktop/experimental/gjs/debian/patches/disable-property-shadow-test.patch?view=markup
OK, thanks. I don't know why it didn't occur to me before to ask this, but it looks like Artful had gobject-introspection 1.53.2 at the time, whereas this test requires this commit https://git.gnome.org/browse/gobject-introspection/commit/?id=d48fb32d8350abbd421658c733b74aaf44cb89ce (1.53.4 or later). It seems that Artful has 1.54.0 now, so you might want to re-enable and try it again.
Thanks for the follow-up! My initial testing shows that the tests pass now so I'm closing this bug.