After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786551 - Possible to add multiple instances of the address field when editing OSM
Possible to add multiple instances of the address field when editing OSM
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2017-08-20 20:38 UTC by Marcus Lundblad
Modified: 2017-08-20 21:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
osmEditDialog: Don't add Address to popover if already added (996 bytes, patch)
2017-08-20 20:59 UTC, Marcus Lundblad 		committed Details | Review

Description Marcus Lundblad 2017-08-20 20:38:02 UTC 
When adding an address entry on an OSM object, the address entry is still selectable in the field selection popover, making it possible to add multiple entries. What's worse is that adding another one actually "overrides" the contents of the first one.
Comment 1 Marcus Lundblad 2017-08-20 20:59:58 UTC 
Created attachment 358033 [details] [review]
osmEditDialog: Don't add Address to popover if already added

Use !== null to check if any subtags under address is already included
(including placeholder empty strings).
Comment 2 Marcus Lundblad 2017-08-20 21:00:24 UTC 
Attachment 358033 [details] pushed as 8a8a7ea - osmEditDialog: Don't add Address to popover if already added