Created attachment 357994 [details] [review]
shell-tray-manager: Disconnect theme_widget signals on finalize

The theme widget passed to shell_tray_manager_manager_screen() is simply
a means to receive style information. There is nothing which ties the two
object's life cycles together, so it is entirely possible for the tray to
be finalized with the widget still around - we shouldn't try to update the
stale object on widget style changes, so make sure we properly disconnect
the signal handler.

Review of attachment 357994 [details] [review]:

Since we don't actually re-set the theme widget, a simple g_signal_connect_object() would be a much simpler solution. This is fine too of course

Attachment 357994 [details] pushed as b5d3c4e - shell-tray-manager: Disconnect theme_widget signals on finalize

(In reply to Rui Matos from comment #2)
> Since we don't actually re-set the theme widget, a simple
> g_signal_connect_object() would be a much simpler solution.

Thanks for the suggestion, that function completely slipped my mind.