GNOME Bugzilla – Bug 786514
Network: segfault when trying to show a wireless device from CLI
Last modified: 2017-08-29 21:12:23 UTC
Created attachment 357976 [details] stacktrace Command to launch: gnome-control-center network show-device /org/freedesktop/NetworkManager/devices/3
Created attachment 358655 [details] [review] network: Don't unref device after when parsing arguments When we add the NetDevice pointer to the GPtrArray, we have a single reference owned by the panel. When iterating over this GPtrArray, no reference is taken. The problem is that the code to handle command-line arguments was unreferencing the NetDevices when iterating over it, creating a disparity in the ref/unref pairs. Fix that by simply not unreferencing the NetDevice instance when iterating over it.
Review of attachment 358655 [details] [review]: lgtm, thanks
Thanks for the review. Attachment 358655 [details] pushed as 5a3b19e - network: Don't unref device after when parsing arguments