After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786462 - Use g_output_stream_write_all instead of while
Use g_output_stream_write_all instead of while
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2017-08-18 11:26 UTC by Ondrej Holy
Modified: 2017-08-18 12:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gio-tool-save: Use g_output_stream_write_all instead of while (1.59 KB, patch)
2017-08-18 11:26 UTC, Ondrej Holy 		none Details | Review
gfile: Use g_output_stream_write_all instead of while (1.53 KB, patch)
2017-08-18 11:28 UTC, Ondrej Holy 		committed Details | Review
gio-tool-save: Use g_output_stream_write_all instead of while (1.61 KB, patch)
2017-08-18 12:43 UTC, Ondrej Holy 		committed Details | Review

Description Ondrej Holy 2017-08-18 11:26:41 UTC 
Simplify the read-write copy code and use g_output_stream_write_all
instead of while and g_output_stream_write.
Comment 1 Ondrej Holy 2017-08-18 11:26:45 UTC 
Created attachment 357884 [details] [review]
gio-tool-save: Use g_output_stream_write_all instead of while
Comment 2 Ondrej Holy 2017-08-18 11:28:20 UTC 
Created attachment 357885 [details] [review]
gfile: Use g_output_stream_write_all instead of while

Simplify the read-write copy code and use g_output_stream_write_all
instead of while and g_output_stream_write.
Comment 3 Philip Withnall 2017-08-18 11:58:24 UTC 
Review of attachment 357884 [details] [review]:

Looks good.
Comment 4 Philip Withnall 2017-08-18 12:00:00 UTC 
Review of attachment 357885 [details] [review]:

Looks good.
Comment 5 Ondrej Holy 2017-08-18 12:43:24 UTC 
Created attachment 357893 [details] [review]
gio-tool-save: Use g_output_stream_write_all instead of while

Adapt on different indentation.
Comment 6 Ondrej Holy 2017-08-18 12:47:44 UTC 
Attachment 357885 [details] pushed as 1cce5dd - gfile: Use g_output_stream_write_all instead of while
Attachment 357893 [details] pushed as 78fa67e - gio-tool-save: Use g_output_stream_write_all instead of while